[eslint-plugin-react-hooks][RulesOfHooks] handle React.useEffect in addition to useEffect #34076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayc0
commented
Aug 1, 2025
Ayc0
commented
Aug 1, 2025
| return false; | ||
| } | ||
|
|
||
| function getNodeWithoutReactNamespace( |
There was a problem hiding this comment.
Copied over from ExhaustiveDeps.ts
Ayc0
commented
Aug 1, 2025
| return node; | ||
| } | ||
|
|
||
| function isUseEffectIdentifier(node: Node): boolean { |
There was a problem hiding this comment.
I could have kept the code inlined, but it makes it a bit more readable
jackpope
requested changes
Aug 11, 2025
|
Comparing: c260b38...5526704 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
jackpope
approved these changes
Aug 18, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Aug 18, 2025
…ddition to useEffect (#34076) ## Summary This is a fix for #34074 ## How did you test this change? I added tests in the eslint package, and ran `yarn jest`. After adding the new tests, I have this: On main | On this branch -|- <img width="356" height="88" alt="image" src="https://github.com/user-attachments/assets/4ae099a1-0156-4032-b2ca-635ebadcaa3f" /> | <img width="435" height="120" alt="image" src="https://github.com/user-attachments/assets/b06c04b8-6cec-43de-befa-a8b4dd20500e" /> ## Changes - Add tests to check that we are checking both `CallExpression` (`useEffect(`), and `MemberExpression` (`React.useEffect(`). To do that, I copied the `getNodeWithoutReactNamespace(` fn from `ExhaustiveDeps.ts` to `RulesOfHooks.ts` DiffTrain build for [87a45ae](87a45ae)
github-actions bot
pushed a commit
that referenced
this pull request
Aug 18, 2025
…ddition to useEffect (#34076) ## Summary This is a fix for #34074 ## How did you test this change? I added tests in the eslint package, and ran `yarn jest`. After adding the new tests, I have this: On main | On this branch -|- <img width="356" height="88" alt="image" src="https://github.com/user-attachments/assets/4ae099a1-0156-4032-b2ca-635ebadcaa3f" /> | <img width="435" height="120" alt="image" src="https://github.com/user-attachments/assets/b06c04b8-6cec-43de-befa-a8b4dd20500e" /> ## Changes - Add tests to check that we are checking both `CallExpression` (`useEffect(`), and `MemberExpression` (`React.useEffect(`). To do that, I copied the `getNodeWithoutReactNamespace(` fn from `ExhaustiveDeps.ts` to `RulesOfHooks.ts` DiffTrain build for [87a45ae](87a45ae)
This was referenced Aug 18, 2025
This was referenced Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a fix for #34074
How did you test this change?
I added tests in the eslint package, and ran
yarn jest. After adding the new tests, I have this:Changes
link:to theeslint-plugin-react-hookspointing tobabel-plugin-react-compilerotherwise it wouldn't run locallyCallExpression(useEffect(), andMemberExpression(React.useEffect(). To do that, I copied thegetNodeWithoutReactNamespace(fn fromExhaustiveDeps.tstoRulesOfHooks.ts