[Flight] Copy the name field of a serialized function debug value #34085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
sebmarkbage
commented
Aug 6, 2025
| return (0, eval)('({' + JSON.stringify(name) + ':class{}})')[ | ||
| name | ||
| ]; | ||
| let fn; |
Collaborator
Author
There was a problem hiding this comment.
We should really take this fallback path whenever there’s a static initializer or static constructor function since that causes a side effect that might be unexpected even if it doesn’t error.
It could also be a security issue if you’re debugging a third party RSC service (which isn’t really supported yet but should minimize the surface).
It’s just tricky. Might have to bail on anything that contains lower case class and static at word boundaries.
Collaborator
Author
There was a problem hiding this comment.
Added this bailout
eps1lon
approved these changes
Aug 7, 2025
sebmarkbage
force-pushed
the
flightfunctionprops
branch
from
6d4dd70 to
01128dd
Compare
Collaborator
Author
|
Unfortunately it seems that Chrome doesn't always use this name as the display name of a class instance even when defined on the constructor. |
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Aug 10, 2025
…cebook#34085) This ensures that if the name is set manually after the declaration, then we get that name when we log the value. For example Node.js `Response` is declared as `_Response` and then later assigned a new name. We should probably really serialize all static enumerable properties but "name" is non-enumerable so it's still a special case. DiffTrain build for [3958d5d](facebook@3958d5d)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Aug 10, 2025
…cebook#34085) This ensures that if the name is set manually after the declaration, then we get that name when we log the value. For example Node.js `Response` is declared as `_Response` and then later assigned a new name. We should probably really serialize all static enumerable properties but "name" is non-enumerable so it's still a special case. DiffTrain build for [3958d5d](facebook@3958d5d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that if the name is set manually after the declaration, then we get that name when we log the value. For example Node.js
Responseis declared as_Responseand then later assigned a new name.We should probably really serialize all static enumerable properties but "name" is non-enumerable so it's still a special case.