Skip to content

[DevTools] Source Map Stack Traces such in await locations #34094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebmarkbage merged 2 commits into from
Aug 6, 2025
+4 −2
Merged

[DevTools] Source Map Stack Traces such in await locations #34094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dded82b
Columns in source maps are returned as zero based but we use one base…
sebmarkbage Aug 5, 2025
d7548ed
Update test
sebmarkbage Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-devtools-shared/src/__tests__/utils-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
exports.f = f;
function f() { }
//# sourceMappingURL=`;
const result = ['', 'http://test/a.mts', 1, 16];
const result = ['', 'http://test/a.mts', 1, 17];
const fs = {
'http://test/a.mts': `export function f() {}`,
'http://test/a.mjs.map': `{"version":3,"file":"a.mjs","sourceRoot":"","sources":["a.mts"],"names":[],"mappings":";;AAAA,cAAsB;AAAtB,SAAgB,CAAC,KAAI,CAAC"}`,
Expand Down
4 changes: 3 additions & 1 deletion packages/react-devtools-shared/src/symbolicateSource.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,14 @@ export async function symbolicateSource(
const {
sourceURL: possiblyURL,
line,
column,
column: columnZeroBased,
} = consumer.originalPositionFor({
lineNumber, // 1-based
columnNumber, // 1-based
});

const column = columnZeroBased + 1;
Copy link
Collaborator Author

@sebmarkbage sebmarkbage Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes an existing issue where we were returning a zero based column when the data structure expects a one based column.


if (possiblyURL === null) {
return null;
}
Expand Down
Loading