Skip to content

Create fresh Offscreen instance when replaying #34127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 11, 2025
Merged

Create fresh Offscreen instance when replaying #34127

merged 4 commits into from
Aug 11, 2025
+78 −36

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Aug 7, 2025 •
edited
Loading

We reset the stateNode when we reset the work-in-progress. So we need to create a new Offscreen instance when we replay.

Fixes Cannot read properties of null (reading "_visibility")

@meta-cla meta-cla bot added the CLA Signed label Aug 7, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Aug 7, 2025
@react-sizebot
Copy link

react-sizebot commented Aug 7, 2025 •
edited
Loading

Comparing: 3958d5d...6ecd2cc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.02% 530.04 kB 530.16 kB = 93.63 kB 93.39 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 654.48 kB 654.53 kB = 115.34 kB 115.11 kB
facebook-www/ReactDOM-prod.classic.js = 674.42 kB 674.30 kB = 118.68 kB 118.29 kB
facebook-www/ReactDOM-prod.modern.js = 664.84 kB 664.73 kB = 117.03 kB 116.64 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 172.84 kB 172.43 kB = 30.79 kB 30.55 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js = 172.72 kB 172.30 kB = 30.75 kB 30.52 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 171.51 kB 171.10 kB = 30.53 kB 30.30 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js = 169.86 kB 169.44 kB = 30.25 kB 30.02 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 167.74 kB 167.32 kB = 29.82 kB 29.59 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js = 167.66 kB 167.24 kB = 30.07 kB 29.84 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js = 167.53 kB 167.12 kB = 30.04 kB 29.81 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js = 167.26 kB 166.84 kB = 29.82 kB 29.59 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js = 166.66 kB 166.25 kB = 29.68 kB 29.44 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js = 165.66 kB 165.24 kB = 29.29 kB 29.06 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js = 164.53 kB 164.11 kB = 29.57 kB 29.34 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js = 164.51 kB 164.10 kB = 29.29 kB 29.05 kB
oss-experimental/react-client/cjs/react-client-flight.development.js = 160.42 kB 160.01 kB = 28.24 kB 28.00 kB
oss-experimental/react-dom/cjs/react-dom-profiling.profiling.js = 720.10 kB 718.11 kB = 125.01 kB 124.47 kB
facebook-www/ReactDOM-profiling.classic.js = 747.61 kB 745.47 kB = 128.52 kB 127.92 kB
facebook-www/ReactDOM-profiling.modern.js = 739.51 kB 737.36 kB = 127.19 kB 126.54 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 131.36 kB 130.94 kB = 24.13 kB 23.91 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 131.36 kB 130.94 kB = 24.13 kB 23.91 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js = 131.23 kB 130.82 kB = 24.09 kB 23.87 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js = 131.23 kB 130.82 kB = 24.09 kB 23.87 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 130.03 kB 129.61 kB = 23.88 kB 23.65 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 130.03 kB 129.61 kB = 23.88 kB 23.65 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js = 128.37 kB 127.96 kB = 23.59 kB 23.36 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js = 128.37 kB 127.96 kB = 23.59 kB 23.36 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-profiling.js = 655.42 kB 653.28 kB = 112.59 kB 112.04 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-profiling.js = 649.49 kB 647.34 kB = 111.45 kB 110.89 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 126.25 kB 125.84 kB = 23.13 kB 22.90 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 126.25 kB 125.84 kB = 23.13 kB 22.90 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js = 126.14 kB 125.72 kB = 23.36 kB 23.13 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js = 126.14 kB 125.72 kB = 23.36 kB 23.13 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js = 126.01 kB 125.59 kB = 23.32 kB 23.09 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js = 126.01 kB 125.59 kB = 23.32 kB 23.09 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js = 125.76 kB 125.34 kB = 23.23 kB 23.01 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js = 125.71 kB 125.29 kB = 23.20 kB 22.98 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js = 125.17 kB 124.75 kB = 23.09 kB 22.86 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js = 125.12 kB 124.70 kB = 23.06 kB 22.84 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js = 124.16 kB 123.74 kB = 22.70 kB 22.47 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js = 124.11 kB 123.69 kB = 22.67 kB 22.45 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js = 123.02 kB 122.60 kB = 22.69 kB 22.47 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js = 123.01 kB 122.59 kB = 22.85 kB 22.62 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js = 123.01 kB 122.59 kB = 22.85 kB 22.62 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js = 122.97 kB 122.55 kB = 22.66 kB 22.44 kB
oss-stable/react-client/cjs/react-client-flight.development.js = 118.93 kB 118.52 kB = 21.60 kB 21.37 kB
oss-stable-semver/react-client/cjs/react-client-flight.development.js = 118.91 kB 118.49 kB = 21.58 kB 21.35 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.js = 544.67 kB 542.72 kB = 85.56 kB 85.00 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 207.23 kB 206.02 kB = 45.80 kB 45.43 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 172.44 kB 171.24 kB = 39.25 kB 38.89 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 172.42 kB 171.21 kB = 39.22 kB 38.86 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,264.99 kB 1,253.56 kB = 209.86 kB 208.40 kB
facebook-www/ReactDOMTesting-dev.modern.js = 1,255.82 kB 1,244.39 kB = 208.13 kB 206.70 kB
facebook-www/ReactDOM-dev.classic.js = 1,248.45 kB 1,237.03 kB = 206.21 kB 204.74 kB
facebook-www/ReactDOM-dev.modern.js = 1,239.28 kB 1,227.86 kB = 204.47 kB 203.00 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js = 1,220.31 kB 1,208.88 kB = 204.19 kB 202.58 kB
oss-experimental/react-dom/cjs/react-dom-profiling.development.js = 1,220.15 kB 1,208.72 kB = 203.40 kB 201.74 kB
oss-experimental/react-dom/cjs/react-dom-client.development.js = 1,203.77 kB 1,192.33 kB = 200.58 kB 198.93 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js = 759.74 kB 752.31 kB = 120.50 kB 119.72 kB
react-native/implementations/ReactFabric-dev.fb.js = 748.08 kB 740.65 kB = 118.76 kB 117.96 kB
facebook-www/ReactART-dev.classic.js = 748.35 kB 740.84 kB = 116.93 kB 116.15 kB
oss-experimental/react-art/cjs/react-art.development.js = 699.34 kB 692.26 kB = 110.35 kB 109.62 kB
facebook-www/ReactART-dev.modern.js = 738.82 kB 731.31 kB = 115.13 kB 114.37 kB
facebook-www/ReactReconciler-dev.classic.js = 864.46 kB 855.54 kB = 133.96 kB 133.24 kB
facebook-www/ReactReconciler-dev.modern.js = 855.23 kB 846.30 kB = 132.16 kB 131.47 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js = 828.46 kB 819.79 kB = 129.28 kB 128.46 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js = 1,135.86 kB 1,123.97 kB = 188.04 kB 186.10 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js = 1,119.59 kB 1,107.70 kB = 185.24 kB 183.28 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 2,107.11 kB 2,084.47 kB = 304.75 kB 301.35 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 2,106.93 kB 2,084.29 kB = 304.72 kB 301.32 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js = 2,106.93 kB 2,084.29 kB = 304.72 kB 301.32 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 2,102.64 kB 2,080.00 kB = 303.75 kB 300.34 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 2,102.46 kB 2,079.82 kB = 303.72 kB 300.32 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js = 2,102.46 kB 2,079.82 kB = 303.72 kB 300.32 kB

Generated by 🚫 dangerJS against 6ecd2cc

@eps1lon eps1lon changed the title Failing test incorrect stateNode reset Create fresh Offscreen instance when replaying Aug 7, 2025
@eps1lon eps1lon force-pushed the sebbie/stateNode-reset branch from 6f61f4f to 9e25af3 Compare August 8, 2025 07:22
@eps1lon eps1lon requested a review from sebmarkbage August 10, 2025 07:59
@eps1lon eps1lon merged commit ac7820a into facebook:main Aug 11, 2025
241 checks passed
@eps1lon eps1lon deleted the sebbie/stateNode-reset branch August 11, 2025 18:55
github-actions bot pushed a commit that referenced this pull request Aug 11, 2025
@eps1lon
Create fresh Offscreen instance when replaying (#34127)
c92ef90 
DiffTrain build for [ac7820a](ac7820a)
github-actions bot pushed a commit that referenced this pull request Aug 11, 2025
@eps1lon
Create fresh Offscreen instance when replaying (#34127)
a0b63cc 
DiffTrain build for [ac7820a](ac7820a)
@nextjs-bot nextjs-bot mentioned this pull request Aug 11, 2025
Merged
@austinderek austinderek mentioned this pull request Aug 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eps1lon @react-sizebot @sebmarkbage