Skip to content

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Aug 8, 2025

The name prop will be used in the Suspense tab to help identity a boundary. Activity will also allow names. A custom component can be identified by the name of the component but built-ins doesn't have that.

This PR adds it to the Components Tree View as well since otherwise you only have the key to go on. Normally we don't add all the props to avoid making this view too noisy but this is an exception along with key to help identify a boundary quickly in the tree.

Unlike the SuspenseNode store, this wouldn't ever have a name inferred by owner since that kind of context already exists in this view.

Screenshot 2025-08-08 at 1 20 36 PM

I also made both the key and name prop searchable.

Screenshot 2025-08-08 at 1 32 27 PM

@sebmarkbage sebmarkbage requested review from eps1lon and hoxyq August 8, 2025 17:33
@meta-cla meta-cla bot added the CLA Signed label Aug 8, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Aug 8, 2025
@react-sizebot
Copy link

Comparing: 3958d5d...a84c2b9

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.04 kB 530.04 kB = 93.63 kB 93.63 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 654.48 kB 654.48 kB = 115.34 kB 115.34 kB
facebook-www/ReactDOM-prod.classic.js = 674.42 kB 674.42 kB = 118.68 kB 118.68 kB
facebook-www/ReactDOM-prod.modern.js = 664.84 kB 664.84 kB = 117.03 kB 117.02 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against a84c2b9

@slorber
Copy link
Contributor

slorber commented Sep 1, 2025

Hey, just wondering what about the other built-in ones? Will we be able to name <Fragment> as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants