Skip to content

Conversation

@sebmarkbage
Copy link
Collaborator

In the case where a Promise is not cached, then the thenable state might contain an older version. This version is the one that was actually observed by the committed render, so that's the version we'll want to inspect.

We used to not store the thenable state but now we have it on _debugThenableState in DEV.

Screenshot 2025-08-10 at 8 26 04 PM

In the case where a Promise is not cached, then the thenable state might
contain an older version. This version is the one that was actually observed
by the committed render, so that's the version we'll want to inspect.
@sebmarkbage sebmarkbage requested review from eps1lon and hoxyq August 11, 2025 00:26
@meta-cla meta-cla bot added the CLA Signed label Aug 11, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Aug 11, 2025
@react-sizebot
Copy link

Comparing: 98286cf...3aae2c2

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.04 kB 530.04 kB = 93.63 kB 93.62 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 654.48 kB 654.48 kB = 115.34 kB 115.34 kB
facebook-www/ReactDOM-prod.classic.js = 674.42 kB 674.42 kB = 118.68 kB 118.68 kB
facebook-www/ReactDOM-prod.modern.js = 664.84 kB 664.84 kB = 117.02 kB 117.02 kB
oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js +2.36% 31.74 kB 32.49 kB +1.94% 5.74 kB 5.85 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js +2.36% 31.74 kB 32.49 kB +1.94% 5.74 kB 5.85 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.development.js +2.36% 31.74 kB 32.49 kB +1.94% 5.74 kB 5.85 kB
oss-experimental/react-debug-tools/cjs/react-debug-tools.production.js +2.33% 28.29 kB 28.95 kB +2.18% 5.61 kB 5.73 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.production.js +2.33% 28.29 kB 28.95 kB +2.18% 5.61 kB 5.73 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.production.js +2.33% 28.29 kB 28.95 kB +2.18% 5.61 kB 5.73 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js +2.36% 31.74 kB 32.49 kB +1.94% 5.74 kB 5.85 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js +2.36% 31.74 kB 32.49 kB +1.94% 5.74 kB 5.85 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.development.js +2.36% 31.74 kB 32.49 kB +1.94% 5.74 kB 5.85 kB
oss-experimental/react-debug-tools/cjs/react-debug-tools.production.js +2.33% 28.29 kB 28.95 kB +2.18% 5.61 kB 5.73 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.production.js +2.33% 28.29 kB 28.95 kB +2.18% 5.61 kB 5.73 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.production.js +2.33% 28.29 kB 28.95 kB +2.18% 5.61 kB 5.73 kB

Generated by 🚫 dangerJS against 3aae2c2

@sebmarkbage sebmarkbage merged commit 62a634b into facebook:main Aug 11, 2025
247 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants