Remove unused arguments from ReactElement #34174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
sebmarkbage
reviewed
Aug 11, 2025
| debugStack, | ||
| debugTask, | ||
| ) { | ||
| function ReactElement(type, key, owner, props, debugStack, debugTask) { |
There was a problem hiding this comment.
Since owner is only tracked in DEV, it probably makes sense to put that after props. We do that elsewhere with dev only arguments since Closure Compiler seems better at removing them when they're always the same given some constant.
sebmarkbage
approved these changes
Aug 11, 2025
After various feature flag removals recently, these arguments became unused and can be deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After various feature flag removals recently, these arguments became unused and can be deleted.