Skip to content

[Fiber] Don't bind retry listener if it's in the cache #34183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2025
Merged

[Fiber] Don't bind retry listener if it's in the cache #34183

merged 1 commit into from
Aug 13, 2025
+1 −1

Conversation

sebmarkbage
Copy link
Collaborator

This did an unnecessary bind allocation even if there's cache hit.

@sebmarkbage sebmarkbage requested a review from eps1lon August 12, 2025 14:39
@meta-cla meta-cla bot added the CLA Signed label Aug 12, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Aug 12, 2025
@react-sizebot
Copy link

Comparing: ac7820a...b4f7244

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.16 kB 530.18 kB = 93.39 kB 93.39 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 654.53 kB 654.55 kB = 115.11 kB 115.11 kB
facebook-www/ReactDOM-prod.classic.js = 674.30 kB 674.32 kB = 118.29 kB 118.29 kB
facebook-www/ReactDOM-prod.modern.js = 664.73 kB 664.74 kB = 116.64 kB 116.65 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against b4f7244

@sebmarkbage sebmarkbage merged commit f1222f7 into facebook:main Aug 13, 2025
474 of 475 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 13, 2025
@sebmarkbage
[Fiber] Don't bind retry listener if it's in the cache (#34183)
46356cd 
This did an unnecessary bind allocation even if there's cache hit.

DiffTrain build for [f1222f7](f1222f7)
github-actions bot pushed a commit that referenced this pull request Aug 13, 2025
@sebmarkbage
[Fiber] Don't bind retry listener if it's in the cache (#34183)
c2ce99c 
This did an unnecessary bind allocation even if there's cache hit.

DiffTrain build for [f1222f7](f1222f7)
@nextjs-bot nextjs-bot mentioned this pull request Aug 13, 2025
Merged
gnoff pushed a commit to vercel/next.js that referenced this pull request Aug 13, 2025
@nextjs-bot
Upgrade React from 1dc3bdea-20250812 to f1222f76-20250812 (#82595)
f889fbd 
[diff
facebook/react@1dc3bdea...f1222f76](facebook/react@1dc3bde...f1222f7)

<details>
<summary>React upstream changes</summary>

- facebook/react#34183
- facebook/react#34192
- facebook/react#34186
- facebook/react#34187

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sebmarkbage @react-sizebot @eps1lon