[DevTools] Avoid renders of stale Suspense store #34396
Merged
+73
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
commented
Sep 5, 2025
|
|
||
| function getDocumentBoundingRect( | ||
| store: Store, | ||
| shells: $ReadOnlyArray<SuspenseNode['id']>, |
Collaborator
Author
There was a problem hiding this comment.
Naming was confusing. The Shell is a slice from Root to the first boundaries. The Root is a single element.
eps1lon
commented
Sep 5, 2025
| function handleFocus() { | ||
| const suspense = timeline[value]; | ||
|
|
||
| dispatch({type: 'SELECT_ELEMENT_BY_ID', payload: suspense.id}); |
Collaborator
Author
There was a problem hiding this comment.
drive-by. Felt odd to not select the element when you tab/click in but then start selecting when values change.
eps1lon
force-pushed
the
sebbie/09-05-_devtools_avoid_renders_of_stale_suspense_store
branch
from
beae8b5 to
7bedd05
Compare
hoxyq
approved these changes
Sep 5, 2025
eps1lon
deleted the
sebbie/09-05-_devtools_avoid_renders_of_stale_suspense_store
branch
This was referenced Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading from the
StoreContextfor suspense related stuff is quite the footgun right now because the Store is mutable. I'm going with a single Hook for reading Suspense related data for now that ensures a re-render until I come up with a better factoring.Still dangerous to close over
useSuspenseStorein memoized functions. But that can be avoided with puttingsuspenseRevisioninto deps.