[compiler] Derive ErrorSeverity from ErrorCategory #34401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 5, 2025
github-actions
bot
added
the
React Core Team
josephsavona
approved these changes
Sep 5, 2025
Member
josephsavona
left a comment
josephsavona
left a comment
There was a problem hiding this comment.
Awesome, thanks for working on this! See comments before landing though, about isError() and similar functions
| let res = false; | ||
| for (const detail of this.details) { | ||
| if (detail.severity === ErrorSeverity.Off) { | ||
| return false; |
Member
There was a problem hiding this comment.
why not just ignore details that are off? maybe instead of returning a boolean, we could have CompilerError.proto.errors(): Array<CompilerDetail> | null and that filters out any details that are off, and returns null if empty?
Member
Author
There was a problem hiding this comment.
Yeah good call. Originally I was thinking, if there's any details that were not meant to be displayed we should just not display the whole thing. But probably better to just filter that out
Comment on lines
+440
to
+475
| /** | ||
| * Returns true if there are no Errors and there is at least one Warning. | ||
| */ | ||
| isWarning(): boolean { | ||
| let res = false; | ||
| for (const detail of this.details) { | ||
| if (detail.severity === ErrorSeverity.Off) { | ||
| return false; | ||
| } | ||
| if (detail.severity === ErrorSeverity.Error) { | ||
| return false; | ||
| } | ||
| if (detail.severity === ErrorSeverity.Warning) { | ||
| res = true; | ||
| } | ||
| } | ||
| return res; | ||
| } | ||
|
|
||
| isHint(): boolean { | ||
| let res = false; | ||
| for (const detail of this.details) { | ||
| if (detail.severity === ErrorSeverity.Off) { | ||
| return false; | ||
| } | ||
| if (detail.severity === ErrorSeverity.Error) { | ||
| return false; | ||
| } | ||
| if (detail.severity === ErrorSeverity.Warning) { | ||
| return false; | ||
| } | ||
| if (detail.severity === ErrorSeverity.Hint) { | ||
| res = true; | ||
| } | ||
| } | ||
| return res; |
Member
There was a problem hiding this comment.
similar here, there isn't a clear semantic meaning for these isFoo() given there are multiple details. feels like it should be more hasFoo()
| case ErrorSeverity.InvalidReact: | ||
| case ErrorSeverity.UnsupportedJS: { | ||
| severityCategory = 'Error'; | ||
| function printErrorSummary(category: ErrorCategory, message: string): string { |
Member
There was a problem hiding this comment.
maybe we should make this a property of the ErrorCategory details object?
Member
Author
There was a problem hiding this comment.
Will address in a follow up
|
Comparing: c4e2508...3a1ff39 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
With #34176 we now have granular lint rules created for each compiler ErrorCategory. However, we had remnants of our old error severities still in use which makes reporting errors quite clunky. Previously you would need to specify both a category and severity which often ended up being the same. This PR moves severity definition into our rules which are generated from our categories. For now I decided to defer "upgrading" categories from a simple string to a sum type since we are only using severities to map errors to eslint severity.
poteto
added a commit
that referenced
this pull request
Sep 6, 2025
Now that we have a new CompilerDiagnostic type (which the CompilerError aggregate can hold), the old CompilerErrorDetail type can be marked as deprecated. Eventually we should migrate everything to the new CompilerDiagnostic type. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34402). * #34409 * #34404 * #34403 * __->__ #34402 * #34401
github-actions bot
pushed a commit
that referenced
this pull request
Sep 6, 2025
With #34176 we now have granular lint rules created for each compiler ErrorCategory. However, we had remnants of our old error severities still in use which makes reporting errors quite clunky. Previously you would need to specify both a category and severity which often ended up being the same. This PR moves severity definition into our rules which are generated from our categories. For now I decided to defer "upgrading" categories from a simple string to a sum type since we are only using severities to map errors to eslint severity. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34401). * #34409 * #34404 * #34403 * #34402 * __->__ #34401 DiffTrain build for [60d9b97](60d9b97)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 6, 2025
With #34176 we now have granular lint rules created for each compiler ErrorCategory. However, we had remnants of our old error severities still in use which makes reporting errors quite clunky. Previously you would need to specify both a category and severity which often ended up being the same. This PR moves severity definition into our rules which are generated from our categories. For now I decided to defer "upgrading" categories from a simple string to a sum type since we are only using severities to map errors to eslint severity. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34401). * #34409 * #34404 * #34403 * #34402 * __->__ #34401 DiffTrain build for [60d9b97](60d9b97)
EugeneChoi4
added a commit
that referenced
this pull request
Sep 8, 2025
The compiler playground was crashing at any small syntax errors in the `Input` panel due to updating the `CompilerErrorDetailOptions` type in #34401. Updated the option to take in a `ErrorCategory` instead. --------- Co-authored-by: lauren <poteto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #34176 we now have granular lint rules created for each compiler ErrorCategory. However, we had remnants of our old error severities still in use which makes reporting errors quite clunky. Previously you would need to specify both a category and severity which often ended up being the same.
This PR moves severity definition into our rules which are generated from our categories. For now I decided to defer "upgrading" categories from a simple string to a sum type since we are only using severities to map errors to eslint severity.
Stack created with Sapling. Best reviewed with ReviewStack.