[playground] ViewTransition on tab switch #34596
Merged
+52
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackpope
approved these changes
Sep 25, 2025
|
|
||
| const handleTabChange = (tab: string): void => { | ||
| startTransition(() => { | ||
| addTransitionType('tab'); |
There was a problem hiding this comment.
Similar to previous PR this type could be a constant in a separate module. Could also be better named, something like 'toggle-tab' to describe the action itself
EugeneChoi4
force-pushed
the
tab-slider
branch
from
a1359e4 to
2c51347
Compare
This was referenced Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Utilized
<ViewTransition>to introduce a sliding animation upon switching between the Output and SourceMap tabs in the default playground view.How did you test this change?
Screen.Recording.2025-09-24.at.3.38.37.PM.mov