Skip to content

Conversation

EugeneChoi4
Copy link
Contributor

Summary

Added <ViewTransition> for when the "Show Internals" button is toggled for a basic fade transition. Additionally added a transition for when tabs are expanded in the advanced view of the Compiler Playground to display a smoother show/hide animation.

How did you test this change?

Screen.Recording.2025-09-24.at.4.36.11.PM.mov

@meta-cla meta-cla bot added the CLA Signed label Sep 24, 2025
@jackpope
Copy link
Contributor

This is coming together nicely!

Another approach here, related to #34595 (comment) is to have the internals tabs slide in to make the animations consistent throughout. If Output is open, that would crossfade itself because the tabs are being removed, but the collapsed tabs could slide in from right. And then hiding internals slides them back out.

@EugeneChoi4
Copy link
Contributor Author

If Output is open, that would crossfade itself because the tabs are being removed, but the collapsed tabs could slide in from right. And then hiding internals slides them back out.

As of now I think it'll be best to keep this as a simple cross fade. It'll be hard to make the animation look clean also because the Output tabs are different sizes to begin with. I would also have to give this output tab a special case rather than grouping it with the other tabs.

@EugeneChoi4 EugeneChoi4 merged commit a55e98f into facebook:main Sep 30, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants