[DevTools] Recommend React Performance tracks if supported when Timeline profiler is not supported #34684
+141
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
commented
Oct 2, 2025
Comment on lines
+2406
to
+2408
| if (supportsPerformanceTracks) { | ||
| profilingFlags |= PROFILING_FLAG_PERFORMANCE_TRACKS_SUPPORT; | ||
| } |
There was a problem hiding this comment.
Probably best to always set that and have a dedicated message for when you have a prod build with performance tracks and click on the timeline profiler?
There was a problem hiding this comment.
Yea, should recommend configuring the profiling build with a link.
sebmarkbage
approved these changes
Oct 2, 2025
rickhanlonii
reviewed
Oct 2, 2025
Comment on lines
45
to
54
| <code className={styles.Code}>react-dom@{'>='}18</code>. React 19.2 | ||
| and above must use{' '} | ||
| <a | ||
| className={styles.Link} | ||
| href="https://react.dev/reference/dev-tools/react-performance-tracks" | ||
| rel="noopener noreferrer" | ||
| target="_blank"> | ||
| React Performance tracks | ||
| </a>{' '} | ||
| instead. |
There was a problem hiding this comment.
- i'd replace "must" with "can"
- would wrap the "react 19.2 ..." message to a new line
- maybe say something about deprecating this and removing in a future release
There was a problem hiding this comment.
I don't think we'll remove it since you can still use it with React 18 which doesn't have performance tracks.
There was a problem hiding this comment.
wrapped the message and adjusted wording to "In React 19.2 and above React Performance tracks can be used."
eps1lon
force-pushed
the
sebbie/10-02-_devtools_recommend_react_performance_tracks_if_supported_when_timeline_profiler_is_not_supported
branch
from
f03175a to
559bfea
Compare
eps1lon
deleted the
sebbie/10-02-_devtools_recommend_react_performance_tracks_if_supported_when_timeline_profiler_is_not_supported
branch
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #34682
Maybe also add a nudge to use the tracks in the flamegraph and ranked sub-tabs of the React Profiler tab?
New message for current versions:
New message for older versions: