[compiler] Update for Zod v3/v4 compatibility #34717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
|
Note: this is a redo of #34710 w fixes |
josephsavona
force-pushed
the
pr34717
branch
2 times, most recently
from
45c2375 to
69fbdea
Compare
josephsavona
changed the title
z.function(args, return) to be compatible across Zod v3 and v4,
josephsavona
changed the title
z.function(args, return) to be compatible across Zod v3 and v4,
|
Comparing: 71753ac...8335312 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
poteto
approved these changes
Oct 3, 2025
Partial redo of #34710. The changes there tried to use `z.function(args, return)` to be compatible across Zod v3 and v4, but Zod 4's function API has completely changed. Instead, I've updated to just use `z.any()` where we expect a function, and manually validate that it's a function before we call the value. We already have validation of the return type (also using Zod).
github-actions bot
pushed a commit
that referenced
this pull request
Oct 3, 2025
Partial redo of #34710. The changes there tried to use `z.function(args, return)` to be compatible across Zod v3 and v4, but Zod 4's function API has completely changed. Instead, I've updated to just use `z.any()` where we expect a function, and manually validate that it's a function before we call the value. We already have validation of the return type (also using Zod). Co-authored-by: kolvian <eliot@pontarelli.com> DiffTrain build for [d6eb735](d6eb735)
github-actions bot
pushed a commit
that referenced
this pull request
Oct 3, 2025
Partial redo of #34710. The changes there tried to use `z.function(args, return)` to be compatible across Zod v3 and v4, but Zod 4's function API has completely changed. Instead, I've updated to just use `z.any()` where we expect a function, and manually validate that it's a function before we call the value. We already have validation of the return type (also using Zod). Co-authored-by: kolvian <eliot@pontarelli.com> DiffTrain build for [d6eb735](d6eb735)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial redo of #34710. The changes there tried to use
z.function(args, return)to be compatible across Zod v3 and v4, but Zod 4's function API has completely changed. Instead, I've updated to just usez.any()where we expect a function, and manually validate that it's a function before we call the value. We already have validation of the return type (also using Zod).