[Fiber] Ensure useEffectEvent reads latest values in forwardRef and memo() Components
#34831
+81
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
commented
Oct 13, 2025
Comment on lines
+865
to
+866
| logContextValue = fireLogContextValue; | ||
| }, []); |
There was a problem hiding this comment.
The original report registered an interval here. Even after rendering with a new context value, the interval continued to log the initial value.
|
Comparing: 1d68bce...6bec011 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
changed the title
forwardRef and memo() ComponentsuseEffectEvent reads latest values in forwardRef and memo() Components
sebmarkbage
approved these changes
Oct 13, 2025
sebmarkbage
pushed a commit
to vercel/next.js
that referenced
this pull request
Oct 14, 2025
[diff facebook/react@ead92181...d7215b49](facebook/react@ead9218...d7215b4) <details> <summary>React upstream changes</summary> - facebook/react#34829 - facebook/react#34827 - facebook/react#34824 - facebook/react#34823 - facebook/react#34831 - facebook/react#34821 </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34818
Seems to me the event payload handling should've gone into the original fallthrough block instead of just handling it for
FunctionComponent: https://github.com/facebook/react/pull/25229/files#diff-9e8ee221dbf99e0ccdad6a63bf63804dea26f1785e2f443dbe92fa835a63b83eL412-L415See first commit for current behavior where Effect Events did not read the latest Context value if used in
React.memoComponents.