Store instance handles in an internal map behind flag#35053
Merged
jackpope merged 1 commit intofacebook:mainfrom Nov 6, 2025
Merged
Store instance handles in an internal map behind flag#35053jackpope merged 1 commit intofacebook:mainfrom
jackpope merged 1 commit intofacebook:mainfrom
Conversation
|
Comparing: 5a2205b...448b6a8 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
josephsavona
approved these changes
Nov 6, 2025
Member
josephsavona
left a comment
josephsavona
left a comment
There was a problem hiding this comment.
Left a couple comments but since everything is gated this seems fine to experiment with
Comment on lines
+153
to
+154
| (parentNode: any)[internalContainerInstanceKey] || | ||
| internalInstanceMap.get(((parentNode: any): InstanceUnion)); |
Member
There was a problem hiding this comment.
below you check internalInstanceMap first instead of the node itself, is it intentional to have different precedence in different places?
Contributor
Author
There was a problem hiding this comment.
In this version I've moved the main instance handle into the internal map but left the container instance handle on the node. So I'm mirroring the existing checks in terms of precedence. This one checks for container first while the other falls back to container.
Comment on lines
+225
to
+226
| internalInstanceMap.get(((node: any): InstanceUnion)) || | ||
| (node: any)[internalContainerInstanceKey]; |
Member
There was a problem hiding this comment.
compare to here for example
github-actions bot
pushed a commit
that referenced
this pull request
Nov 6, 2025
We already append `randomKey` to each handle name to prevent external libraries from accessing and relying on these internals. But more libraries recently have been getting around this by simply iterating over the element properties and using a `startsWith` check. This flag allows us to experiment with moving these handles to an internal map. This PR starts with the two most common internals, the props object and the fiber. We can consider moving additional properties such as the container root and others depending on perf results. DiffTrain build for [a44e750](a44e750)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 6, 2025
We already append `randomKey` to each handle name to prevent external libraries from accessing and relying on these internals. But more libraries recently have been getting around this by simply iterating over the element properties and using a `startsWith` check. This flag allows us to experiment with moving these handles to an internal map. This PR starts with the two most common internals, the props object and the fiber. We can consider moving additional properties such as the container root and others depending on perf results. DiffTrain build for [a44e750](a44e750)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Nov 9, 2025
We already append `randomKey` to each handle name to prevent external libraries from accessing and relying on these internals. But more libraries recently have been getting around this by simply iterating over the element properties and using a `startsWith` check. This flag allows us to experiment with moving these handles to an internal map. This PR starts with the two most common internals, the props object and the fiber. We can consider moving additional properties such as the container root and others depending on perf results. DiffTrain build for [a44e750](facebook@a44e750)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Nov 9, 2025
We already append `randomKey` to each handle name to prevent external libraries from accessing and relying on these internals. But more libraries recently have been getting around this by simply iterating over the element properties and using a `startsWith` check. This flag allows us to experiment with moving these handles to an internal map. This PR starts with the two most common internals, the props object and the fiber. We can consider moving additional properties such as the container root and others depending on perf results. DiffTrain build for [a44e750](facebook@a44e750)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already append
randomKeyto each handle name to prevent external libraries from accessing and relying on these internals. But more libraries recently have been getting around this by simply iterating over the element properties and using astartsWithcheck.This flag allows us to experiment with moving these handles to an internal map.
This PR starts with the two most common internals, the props object and the fiber. We can consider moving additional properties such as the container root and others depending on perf results.