Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Dec 15, 2025

The repository root was hidden in string length assertions. Those broke once you tested React deeper in your filesystem.

Added the repo root behind a global __REACT_ROOT_PATH_TEST__ since that's used in a couple of places. Defining that for each test makes it annoying to move test file around.

@meta-cla meta-cla bot added the CLA Signed label Dec 15, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Dec 15, 2025
@eps1lon eps1lon force-pushed the sebbie/12-15-_test_exclude_repository_root_from_assertions branch from 596d595 to da6c9b1 Compare December 15, 2025 09:47
@eps1lon eps1lon requested a review from unstubbable December 15, 2025 09:47
@eps1lon eps1lon marked this pull request as ready for review December 15, 2025 09:47
@react-sizebot
Copy link

Comparing: b061b59...da6c9b1

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 608.16 kB 608.16 kB = 107.67 kB 107.67 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 667.39 kB 667.39 kB = 117.55 kB 117.55 kB
facebook-www/ReactDOM-prod.classic.js = 693.47 kB 693.47 kB = 122.05 kB 122.05 kB
facebook-www/ReactDOM-prod.modern.js = 683.89 kB 683.89 kB = 120.43 kB 120.43 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against da6c9b1

@eps1lon eps1lon merged commit ba5b843 into facebook:main Dec 15, 2025
242 checks passed
@eps1lon eps1lon deleted the sebbie/12-15-_test_exclude_repository_root_from_assertions branch December 15, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants