[tests] Add missing component stacks#35495
Closed
rickhanlonii wants to merge 3 commits intofacebook:mainfrom
Closed
[tests] Add missing component stacks#35495rickhanlonii wants to merge 3 commits intofacebook:mainfrom
rickhanlonii wants to merge 3 commits intofacebook:mainfrom
Conversation
Update test assertions to include the complete component stack trace rather than partial stacks. This ensures tests validate the full owner stack as it would appear in development.
github-actions
bot
added
the
React Core Team
|
Comparing: 5aec1b2...6e8deb0 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Member
Author
|
yeah i'm not fucking with a stack on this anymore, merging into #35497 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds component stacks to the messages missing them, so we can match on exact error message