[DevTools] Fix crash when revealing stable, filtered <Activity> children#35734
Merged
eps1lon merged 2 commits intofacebook:mainfrom Feb 9, 2026
Merged
[DevTools] Fix crash when revealing stable, filtered <Activity> children#35734eps1lon merged 2 commits intofacebook:mainfrom
<Activity> children#35734eps1lon merged 2 commits intofacebook:mainfrom
Conversation
github-actions
bot
added
the
React Core Team
eps1lon
changed the title
<Activity> children
hoxyq
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This aligns the hidden -> visible Activity path with how we treat hidden Activity. Since we don't mount hidden Activity children, we need to switch to the mount path when updating an Activity from hidden to visible.
This mostly went unnoticed since the update that reveals Activity also created fresh children. But for children from props, we continue down the update path and then later crash because children unexpectedly changed.
Originally I added an extra
isReconnectingSubtreebefore realizing the whole transition from hidden to visible wasn't correctly modelled.How did you test this change?
The children should not have changed if we pass in the same set.)