Consistent handling of work tags for rename, delete, and overriding state#35740
Merged
eps1lon merged 2 commits intofacebook:mainfrom Feb 10, 2026
Conversation
|
Thanks
…On Tue, Feb 10, 2026 at 9:43 AM eps1lon ***@***.***> wrote:
Mostly to make it easier to reason locally about this code. Rename and
delete relied implicitly on inspectElementRaw to only show state for
Class Components but there was already a TODO to expand that which would've
crashed rename and delete.
Flagged by Claude + Opus 4.6 (which didn't make the connection with
inspectElementRaw and assumed this fixes a crash).
------------------------------
You can view, comment on, or merge this pull request online at:
#35740
Commit Summary
- c9e7491
<c9e7491>
Consistent handling of work tags for rename, delete, and overriding state
File Changes
(1 file <https://github.com/facebook/react/pull/35740/files>)
- *M* packages/react-devtools-shared/src/backend/fiber/renderer.js
<https://github.com/facebook/react/pull/35740/files#diff-8ae63f88771a655cbfd17ca09f494a22b1c6c2a1211c8c9c4e8c40d15f0a4a7a>
(20)
Patch Links:
- https://github.com/facebook/react/pull/35740.patch
- https://github.com/facebook/react/pull/35740.diff
—
Reply to this email directly, view it on GitHub
<#35740>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B4CX4CB4Y62USB6TUU3OAOD4LGR3FAVCNFSM6AAAAACUS2CZ4OVHI2DSMVQWIX3LMV43ASLTON2WKOZTHEZDANBQGU3TEMA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
hoxyq
reviewed
Feb 10, 2026
Co-authored-by: Ruslan Lesiutin <28902667+hoxyq@users.noreply.github.com>
hoxyq
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly to make it easier to reason locally about this code. Rename and delete relied implicitly on
inspectElementRawto only show state for Class Components but there was already a TODO to expand that which would've crashed rename and delete.Flagged by Claude + Opus 4.6 (which didn't make the connection with
inspectElementRawand assumed this fixes a crash).