Skip to content

[DevTools] Display React.optimisticKey in key positions#35760

Merged
eps1lon merged 2 commits intofacebook:mainfrom
eps1lon:sebbie/optimisticKey
Feb 10, 2026
Merged

[DevTools] Display React.optimisticKey in key positions#35760
eps1lon merged 2 commits intofacebook:mainfrom
eps1lon:sebbie/optimisticKey

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Feb 10, 2026

Summary

Current display was inconsistent (omitted when inspecting while stringified as Symbol(react.optimistic_key) in the tree).

This displays it as React.optimisticKey mirroring the export.

How did you test this change?

  • Added test

@meta-cla meta-cla bot added the CLA Signed label Feb 10, 2026
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Feb 10, 2026
@eps1lon eps1lon force-pushed the sebbie/optimisticKey branch from 4c3bc45 to 4c18085 Compare February 10, 2026 17:54
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opted for a new test. The store test is already getting crowded and should be split into Activty, Suspense etc versions anyway.

@aydenhailey78-hub

This comment was marked as spam.

@djhdusjbd-eng

This comment was marked as spam.

@eps1lon eps1lon requested a review from hoxyq February 10, 2026 18:39
@eps1lon eps1lon marked this pull request as ready for review February 10, 2026 18:40
@eps1lon eps1lon merged commit e49335e into facebook:main Feb 10, 2026
237 checks passed
@eps1lon eps1lon deleted the sebbie/optimisticKey branch February 10, 2026 23:35
github-actions bot pushed a commit to code/lib-react that referenced this pull request Feb 15, 2026
github-actions bot pushed a commit to code/lib-react that referenced this pull request Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants