Make DOM wrapper component using lower-level primitives #3976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebmarkbage Is this what you were thinking? |
| value: value != null ? value : this._wrapperState.initialValue, | ||
| checked: checked != null ? checked : this._wrapperState.initialChecked, | ||
| onChange: this._wrapperState.onChange | ||
| }); |
There was a problem hiding this comment.
This copying should be avoidable now that we don't have to adhere to a common pretty API but fine as a first step.
sophiebits
force-pushed
the
no-wrapper
branch
2 times, most recently
from
f802daa to
503422b
Compare
|
@sebmarkbage r? If this is good then I'll convert the others too (in a separate PR). |
|
thx |
Introducing: a really lame version of composite components, right inside of ReactDOMComponent! Now ReactDOMInput isn't an actual component. This brings us closer to exposing DOM nodes as refs.
|
Travis is erroring (due to nvm problems?) but unit tests and lint pass locally for me. |
sophiebits
added a commit
that referenced
this pull request
Jun 2, 2015
Make DOM wrapper component using lower-level primitives
|
I'm so excited about this diff and the future ones like it! |
|
Just noticed this PR after working on ES3 native components as we discussed in #2895 (comment). Will you be converting all native components to this pattern? |
|
Yes |
|
Ah, yes. Sorry for the mixup, but it sounds like this will solve your problem too. |
|
Ok, great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing: a really lame version of composite components, right inside of ReactDOMComponent!
Now ReactDOMInput isn't an actual component. This brings us closer to exposing DOM nodes as refs.