Add a method to filter wrappers depending on the DOM #4353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! This is a bit of an unnecessarily generic solution to a simple problem. Can't you just feature test inside ReactInputSelection instead? It is generally bad practice to rely on a generic feature test to determine something more specific about the environment. |
|
I'm closing this PR because I no longer need this change. Thanks for reviewing it though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minimal approach for a solution to the problems related to transaction wrappers trying to access the DOM in its absence.
Surely this requires more work including some new tests as at this point all tests are passing even when the only wrapper being filtered out is
SELECTION_RESTORATION.Is this a workable path? All suggestions are welcome.
Related to #3620 and #4019.