-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn when using a minified copy of dev React #5083
Conversation
Idea; since you actually enable name mangling and optimizations separately, what about checking |
@@ -74,6 +74,15 @@ if (__DEV__) { | |||
} | |||
} | |||
|
|||
function testFn() {} | |||
warning( | |||
(testFn.name || testFn.toString()).indexOf('testFn') !== -1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's smart.
@syranide Haha, interesting. In theory, a good optimizer would replace |
@jimfb That applies to the original code as well. It would also be an invalid optimization as |
👍 |
Warn when using a minified copy of dev React
Hi, the short URL https://fb.me/react-minification does not redirect to something meaningful now. There is not download page now. |
I updated the URL to point somewhere more relevant. |
Fixes #4842.