Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop generating gh-pages during release, update message #5147

Merged
merged 1 commit into from
Oct 13, 2015
Merged

Stop generating gh-pages during release, update message #5147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 3 additions & 28 deletions grunt/tasks/release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ var BOWER_FILES = [
'react-dom.js',
'react-dom.min.js',
];
var GH_PAGES_PATH = '../react-gh-pages/';
var GH_PAGES_GLOB = [GH_PAGES_PATH + '*'];

var EXAMPLES_PATH = 'examples/';
var EXAMPLES_GLOB = [EXAMPLES_PATH + '**/*.*'];
Expand Down Expand Up @@ -75,12 +73,6 @@ function setup() {
return false;
}

if (!grunt.file.exists(GH_PAGES_PATH)) {
grunt.log.error('Make sure you have the react gh-pages branch checked ' +
'out at ../react-gh-pages.');
return false;
}

VERSION = grunt.config.data.pkg.version;
VERSION_STRING = 'v' + VERSION;
}
Expand All @@ -104,28 +96,9 @@ function bower() {
}

function docs() {
var done = this.async();

grunt.file.copy('build/react-' + VERSION + '.zip', 'docs/downloads/react-' + VERSION + '.zip');
grunt.file.copy('build/react.js', 'docs/js/react.js');
grunt.file.copy('build/react-dom.js', 'docs/js/react-dom.js');

var files = grunt.file.expand(GH_PAGES_GLOB);
files.forEach(function(file) {
grunt.file.delete(file, {force: true});
});

// Build the docs with `rake release`, which will compile the CSS & JS, then
// build jekyll into GH_PAGES_PATH
var rakeOpts = {
cmd: 'rake',
args: ['release'],
opts: {cwd: 'docs'},
};
grunt.util.spawn(rakeOpts, function() {
// Commit the repo. We don't really care about tagging this.
_gitCommitAndTag(GH_PAGES_PATH, VERSION_STRING, null, done);
});
}

function msg() {
Expand All @@ -134,8 +107,10 @@ function msg() {
var steps = [
'Still todo:',
'* put files on CDN',
'* add starter pack (git add -f docs/downloads/react-version.zip)',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this part still important?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

… yea, it is. oops

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to commit, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea but I figured the people doing this (me and you) are smart enough to know that. This isn't meant to be a complete step by step but a gentle reminder

'* push changes to git repositories',
'* publish npm module (`npm publish .`)',
'* update docs branch variable in Travis CI',
'* publish npm modules',
'* announce it on FB/Twitter/mailing list',
];
steps.forEach(function(ln) {
Expand Down