-
Notifications
You must be signed in to change notification settings - Fork 47.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix homepage URLs in package.json files #5917
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@@ -5,7 +5,7 @@ | |||
"keywords": [ | |||
"react" | |||
], | |||
"homepage": "https://github.com/facebook/react/tree/master/npm-react", | |||
"homepage": "https://facebook.github.io/react/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you actually just make both of them use this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
@zeke updated the pull request. |
@zpao is it customary to put |
We don't really care about the [ci skip](though we could and this would be a prime candidate). Could you squash the commits and then I'll merge. Thanks! |
:squashed: |
Thanks! |
Fix homepage URLs in package.json files
🍰 |
I'm getting 404s for the current hompage URLs:
This PR updates them: