Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix homepage URLs in package.json files #5917

Merged
merged 1 commit into from
Jan 25, 2016
Merged

Conversation

zeke
Copy link
Contributor

@zeke zeke commented Jan 25, 2016

I'm getting 404s for the current hompage URLs:

$ npm info react-dom homepage
https://github.com/facebook/react/tree/master/npm-react-dom

$ npm info react homepage 
https://github.com/facebook/react/tree/master/npm-react

This PR updates them:

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@@ -5,7 +5,7 @@
"keywords": [
"react"
],
"homepage": "https://github.com/facebook/react/tree/master/npm-react",
"homepage": "https://facebook.github.io/react/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you actually just make both of them use this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@facebook-github-bot
Copy link

@zeke updated the pull request.

@zeke
Copy link
Contributor Author

zeke commented Jan 25, 2016

@zpao is it customary to put [ci skip] on a commit like this? If so, let me know and I can repush if needed.

@zpao
Copy link
Member

zpao commented Jan 25, 2016

We don't really care about the [ci skip](though we could and this would be a prime candidate). Could you squash the commits and then I'll merge. Thanks!

@zeke
Copy link
Contributor Author

zeke commented Jan 25, 2016

:squashed:

@zpao
Copy link
Member

zpao commented Jan 25, 2016

Thanks!

zpao added a commit that referenced this pull request Jan 25, 2016
Fix homepage URLs in package.json files
@zpao zpao merged commit ea79138 into facebook:master Jan 25, 2016
@zeke zeke deleted the homepage-urls branch January 25, 2016 21:17
@zeke
Copy link
Contributor Author

zeke commented Jan 25, 2016

🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants