Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suppressContentEditableWarning #6112

Merged
merged 1 commit into from
Feb 24, 2016

Conversation

mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Feb 24, 2016

I went with suppressContentEditableWarning for now, but that's a quick change.

See #5837

/cc @jimfb @spicyj

@mxstbr mxstbr force-pushed the surpressContentEditableWarning branch from d5699e2 to 35484e5 Compare February 24, 2016 19:35
@sophiebits
Copy link
Collaborator

suppress, not sur

@mxstbr mxstbr force-pushed the surpressContentEditableWarning branch from 35484e5 to f7276b3 Compare February 24, 2016 19:41
@mxstbr mxstbr changed the title Add surpressContentEditableWarning Add suppressContentEditableWarning Feb 24, 2016
@mxstbr
Copy link
Contributor Author

mxstbr commented Feb 24, 2016

The one thing I could have gotten wrong... Fixed, thanks!

@facebook-github-bot
Copy link

@mxstbr updated the pull request.

@jimfb
Copy link
Contributor

jimfb commented Feb 24, 2016

Looks good, thanks @mxstbr!

jimfb added a commit that referenced this pull request Feb 24, 2016
@jimfb jimfb merged commit 7a3009c into facebook:master Feb 24, 2016
@mxstbr mxstbr deleted the surpressContentEditableWarning branch February 24, 2016 21:07
@mxstbr
Copy link
Contributor Author

mxstbr commented Feb 24, 2016

Awesome!

mxstbr added a commit to mxstbr/draft-js that referenced this pull request Feb 24, 2016
This will come into effect with the 15.0 release of React, see facebook/react#6112

Fixes facebookarchive#53
flarnie added a commit to flarnie/draft-js that referenced this pull request Sep 20, 2016
The issue with 'React ContentEditable Warning' was resolved when React
added the 'suppressContentEditableWarning' option[1] and then we used it
in Draft.js[2]. This doesn't need to be in the docs any more.

[1]: facebook/react#6112
[2]: facebookarchive#98
ouchxp pushed a commit to ouchxp/draft-js that referenced this pull request Apr 7, 2017
The issue with 'React ContentEditable Warning' was resolved when React
added the 'suppressContentEditableWarning' option[1] and then we used it
in Draft.js[2]. This doesn't need to be in the docs any more.

[1]: facebook/react#6112
[2]: facebookarchive#98
midas19910709 added a commit to midas19910709/draft-js that referenced this pull request Mar 30, 2022
The issue with 'React ContentEditable Warning' was resolved when React
added the 'suppressContentEditableWarning' option[1] and then we used it
in Draft.js[2]. This doesn't need to be in the docs any more.

[1]: facebook/react#6112
[2]: facebookarchive/draft-js#98
alicayan008 pushed a commit to alicayan008/draft-js that referenced this pull request Jul 4, 2023
The issue with 'React ContentEditable Warning' was resolved when React
added the 'suppressContentEditableWarning' option[1] and then we used it
in Draft.js[2]. This doesn't need to be in the docs any more.

[1]: facebook/react#6112
[2]: facebookarchive/draft-js#98
aforismesen added a commit to aforismesen/draft-js that referenced this pull request Jul 12, 2024
The issue with 'React ContentEditable Warning' was resolved when React
added the 'suppressContentEditableWarning' option[1] and then we used it
in Draft.js[2]. This doesn't need to be in the docs any more.

[1]: facebook/react#6112
[2]: facebookarchive/draft-js#98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants