Warn when setState called within getChildContext #6135
Closed
+35
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’m afraid there is already work in progress in #6121 — it wasn’t linked to from the issue. I added a link. |
|
I’ll close since work on #6121 started earlier, is pretty close to being done, and uses the devtool API that we try to use for new warnings. Thanks for contributing! |
|
Thank you vslinko! I used where you were placing the code as the way to fix the issue |
|
I'm glad to hear that 😄 |
|
Yeah I will that's on me!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #6114
I guess that we should reject update to prevent "maximum call stack" error.
@jimfb what are you think?