Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs external sidebar followup #6151

Merged
merged 2 commits into from
Mar 1, 2016
Merged

Docs external sidebar followup #6151

merged 2 commits into from
Mar 1, 2016

Conversation

zpao
Copy link
Member

@zpao zpao commented Mar 1, 2016

Followup to #6090

  • Fixes the extraneous class=""
  • Adds actual redirect in case those pages are linked to (as best as we can do on GH pages). I didn't use the built-in functionality of the redirect_from gem because it seems to generate pages in the wrong place so had to do the layout manually (also why I used the more awkward dest_url key).

@zpao zpao mentioned this pull request Mar 1, 2016
Merged
@joecritch
Copy link
Contributor

Thanks @zpao. Good shout on the redirect layout.

@jimfb
Copy link
Contributor

jimfb commented Mar 1, 2016

👍

zpao added a commit that referenced this pull request Mar 1, 2016
@zpao
Merge pull request #6151 from zpao/docs-external-sidebar-followup
4da7e7e 
Docs external sidebar followup
@zpao zpao merged commit 4da7e7e into facebook:master Mar 1, 2016
zpao added a commit that referenced this pull request Mar 7, 2016
@zpao
Merge pull request #6151 from zpao/docs-external-sidebar-followup
25fdaf9 
Docs external sidebar followup
(cherry picked from commit 4da7e7e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zpao @joecritch @jimfb @facebook-github-bot