Warn if the included mixin is undefined #6158

swaroopsm · 2016-03-01T18:23:27Z

No description provided.

facebook-github-bot · 2016-03-01T18:23:59Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

jimfb · 2016-03-01T18:35:09Z

src/isomorphic/classic/class/ReactClass.js

@@ -437,6 +437,12 @@ function validateMethodOverride(isAlreadyDefined, name) {
 */
 function mixSpecIntoComponent(Constructor, spec) {
  if (!spec) {
+    warning(


Should wrap this in a __DEV__ block.

facebook-github-bot · 2016-03-01T19:01:53Z

@swaroopsm updated the pull request.

jimfb · 2016-03-01T19:04:08Z

src/isomorphic/classic/class/ReactClass.js

+      var typeofSpec = typeof spec;
+
+      warning(
+        typeofSpec !== 'object' || typeofSpec === null,


What is || typeofSpec === null protecting against?

Oh my bad. I meant spec === null.

Also, I think the typeofSpec !== 'object' check here might be backwards. Warning behaves the opposite of an if statement, if I recall correctly. We should probably add a couple of unit tests to verify behavior.

Ah right. Warning behaves the opposite of an if statement.

facebook-github-bot · 2016-03-01T19:48:53Z

@swaroopsm updated the pull request.

jimfb · 2016-03-01T20:17:29Z

src/isomorphic/classic/class/ReactClass.js

@@ -437,6 +437,20 @@ function validateMethodOverride(isAlreadyDefined, name) {
 */
 function mixSpecIntoComponent(Constructor, spec) {
  if (!spec) {
+    if(__DEV__) {
+      var typeofSpec = typeof spec,
+          isMixinValid = typeofSpec === 'object' && spec !== null;


Let's just add another var statement, put a semicolon on the previous line.

jimfb · 2016-03-01T20:17:57Z

One nit pick. Let's also add a few unit tests, and then I think this is ready to go.

facebook-github-bot · 2016-03-01T21:12:00Z

@swaroopsm updated the pull request.

jimfb · 2016-03-01T21:28:52Z

Ok, looks good to me. Let's squash these commits (git rebase -i, git push -f) and I'll leave it open for a day to see if there is any other feedback before we merge.

zpao · 2016-03-02T00:07:07Z

src/isomorphic/classic/class/ReactClass.js

@@ -437,6 +437,20 @@ function validateMethodOverride(isAlreadyDefined, name) {
 */
 function mixSpecIntoComponent(Constructor, spec) {
  if (!spec) {
+    if(__DEV__) {


Note: this should be failing lint (travis is really behind though 😢)

zpao · 2016-03-02T00:12:32Z

@jimfb before you merge, can you read through #1305 which we didn't merge in part due to issues with jest mocking (many mocked things become undefined which was really noisy internally). It would be good to test this internally and see what the ramifications are. (Though that was before we had createWarning so we can now probably exclude this warning from tests)

facebook-github-bot · 2016-03-02T05:40:57Z

@swaroopsm updated the pull request.

facebook-github-bot · 2016-04-11T07:12:08Z

@swaroopsm updated the pull request.

gaearon · 2016-04-11T12:53:00Z

Let’s also add a test for this “mixin defines a mixin” case.

facebook-github-bot · 2016-04-11T13:43:16Z

@swaroopsm updated the pull request.

facebook-github-bot · 2016-04-11T17:30:35Z

@swaroopsm updated the pull request.

gaearon · 2016-04-11T18:05:06Z

src/isomorphic/classic/class/ReactClass.js

+        '%s: You\'re attempting to include a mixin that is either null ' +
+        'or not an object. Check the mixins included by the component, ' +
+        'as well as any mixins they include themselves. ' +
+        'Expected object but got %s.',


As far as I can see, this will print Expected object but got object. for arrays.

Yeah right. IMHO, I don't think there might be a case where an array will be included as mixin? The docs also has an example with a mixin being an object. Thoughts?

I mean that we should avoid confusing warnings even if turn up in edge cases.
We could do something like

var type; if (spec == null) { type = '' + spec; } else if (Array.isArray(spec)) { type = 'array'; } else { type = typeof spec; }

As noted below, you’re right—we’ll never get into this block with arrays anyway so it doesn’t matter. I was wrong!

gaearon · 2016-04-12T14:57:39Z

Now the only thing holding this back is @zpao sharing his thoughts on how we want to do branches now that we use major versions. Thank you for your work!

gaearon · 2016-06-26T19:14:03Z

LGTM

gaearon · 2016-06-27T00:39:15Z

Note: #7126 will need to get merged right after this because this PR used Jasmine 1 assertion format.

(cherry picked from commit 18bad06)

(cherry picked from commit a49b7a2)

facebook-github-bot added the GH Review: review-needed label Mar 1, 2016

jimfb reviewed Mar 1, 2016
View reviewed changes

jimfb added GH Review: needs-revision and removed GH Review: review-needed labels Mar 1, 2016

swaroopsm force-pushed the warn-undefined-mixin branch from d2407c7 to 0fa4265 Compare March 1, 2016 18:50

facebook-github-bot added GH Review: review-needed and removed GH Review: needs-revision labels Mar 1, 2016

jimfb reviewed Mar 1, 2016
View reviewed changes

swaroopsm force-pushed the warn-undefined-mixin branch from 0fa4265 to f3b9f0c Compare March 1, 2016 19:34

jimfb reviewed Mar 1, 2016
View reviewed changes

swaroopsm force-pushed the warn-undefined-mixin branch from f3b9f0c to 8341f31 Compare March 1, 2016 21:09

jimfb added GH Review: accepted and removed GH Review: review-needed labels Mar 1, 2016

jimfb self-assigned this Mar 1, 2016

swaroopsm force-pushed the warn-undefined-mixin branch from 8341f31 to 5aea1d3 Compare March 1, 2016 21:33

zpao reviewed Mar 2, 2016
View reviewed changes

swaroopsm force-pushed the warn-undefined-mixin branch from 5aea1d3 to 9777b4d Compare March 2, 2016 05:39

swaroopsm force-pushed the warn-undefined-mixin branch from 6274565 to 3d03798 Compare April 11, 2016 13:42

Warn if the included mixin is undefined

331b6de

swaroopsm force-pushed the warn-undefined-mixin branch from 3d03798 to 331b6de Compare April 11, 2016 17:21

gaearon reviewed Apr 11, 2016
View reviewed changes

zpao modified the milestones: 15.y.0, 15-next Jun 1, 2016

zpao modified the milestone: 15-next Jun 14, 2016

gaearon added the semver-minor label Jun 26, 2016

gaearon merged commit 18bad06 into facebook:master Jun 26, 2016

gaearon added this to the 15-next milestone Jun 27, 2016

gaearon added a commit that referenced this pull request Jun 27, 2016

Fix tests from #6158 to use Jasmine 2 (#7126)

a49b7a2

gaearon unassigned jimfb Jun 27, 2016

zpao modified the milestones: 15-next, 15.3.0 Jul 13, 2016

zpao pushed a commit that referenced this pull request Jul 13, 2016

Warn if the included mixin is undefined (#6158)

9d385ef

(cherry picked from commit 18bad06)

zpao pushed a commit that referenced this pull request Jul 13, 2016

Fix tests from #6158 to use Jasmine 2 (#7126)

891e087

(cherry picked from commit a49b7a2)

renovate bot mentioned this pull request Feb 2, 2018

Update dependency react to v0.14.9 - autoclosed signavio/backbone-rel#29

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Warn if the included mixin is undefined #6158

Warn if the included mixin is undefined #6158

swaroopsm commented Mar 1, 2016

facebook-github-bot commented Mar 1, 2016

jimfb Mar 1, 2016

facebook-github-bot commented Mar 1, 2016

jimfb Mar 1, 2016

swaroopsm Mar 1, 2016

jimfb Mar 1, 2016

swaroopsm Mar 1, 2016

facebook-github-bot commented Mar 1, 2016

jimfb Mar 1, 2016

jimfb commented Mar 1, 2016

facebook-github-bot commented Mar 1, 2016

jimfb commented Mar 1, 2016

zpao Mar 2, 2016

zpao commented Mar 2, 2016

facebook-github-bot commented Mar 2, 2016

facebook-github-bot commented Apr 11, 2016

gaearon commented Apr 11, 2016

facebook-github-bot commented Apr 11, 2016

facebook-github-bot commented Apr 11, 2016

gaearon Apr 11, 2016

swaroopsm Apr 11, 2016

gaearon Apr 11, 2016

gaearon Apr 12, 2016

gaearon commented Apr 12, 2016

gaearon commented Jun 26, 2016

gaearon commented Jun 27, 2016

Warn if the included mixin is undefined #6158

Warn if the included mixin is undefined #6158

Conversation

swaroopsm commented Mar 1, 2016

facebook-github-bot commented Mar 1, 2016

Choose a reason for hiding this comment

facebook-github-bot commented Mar 1, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot commented Mar 1, 2016

Choose a reason for hiding this comment

jimfb commented Mar 1, 2016

facebook-github-bot commented Mar 1, 2016

jimfb commented Mar 1, 2016

Choose a reason for hiding this comment

zpao commented Mar 2, 2016

facebook-github-bot commented Mar 2, 2016

facebook-github-bot commented Apr 11, 2016

gaearon commented Apr 11, 2016

facebook-github-bot commented Apr 11, 2016

facebook-github-bot commented Apr 11, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaearon commented Apr 12, 2016

gaearon commented Jun 26, 2016

gaearon commented Jun 27, 2016