createChainableTypeChecker suggests mistyped props by case #6173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| `\`${componentName}\`.`; | ||
| var lowerPropName = propName.toLowerCase(); | ||
| if (props[lowerPropName] != null) { | ||
| message += ` Did you mistype \`${lowerPropName}\`?` |
There was a problem hiding this comment.
Let's say "miscapitalize" instead of "mistype"; it's a little more clear.
|
Also, I think the location of this code seems wrong. You put this logic inside isRequired, which means it will only fire if the prop is required, but we want to fire in all cases of an incorrectly cased prop. Also, new warnings should be added via a devtool (as an example, take a look at #6121) |
|
#6255 seems closer, so I'm going to close this out in favor of that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly addressing #6153