Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ReactPerf.getLastMeasurements() opaque #6286

Merged
merged 1 commit into from
Mar 17, 2016
Merged

Make ReactPerf.getLastMeasurements() opaque #6286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/test/ReactDefaultPerf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,17 @@ function getID(inst) {
}
}

// This implementation of ReactPerf is going away some time mid 15.x.
// While we plan to keep most of the API, the actual format of measurements
// will change dramatically. To signal this, we wrap them into an opaque-ish
// object to discourage reaching into it until the API stabilizes.
function wrapLegacyMeasurements(measurements) {
return { __unstable_this_format_will_change: measurements };
}
function unwrapLegacyMeasurements(measurements) {
return measurements && measurements.__unstable_this_format_will_change || measurements;
}

var ReactDefaultPerf = {
_allMeasurements: [], // last item in the list is the current one
_mountStack: [0],
Expand All @@ -71,11 +82,11 @@ var ReactDefaultPerf = {
},

getLastMeasurements: function() {
return ReactDefaultPerf._allMeasurements;
return wrapLegacyMeasurements(ReactDefaultPerf._allMeasurements);
},

printExclusive: function(measurements) {
measurements = measurements || ReactDefaultPerf._allMeasurements;
measurements = unwrapLegacyMeasurements(measurements || ReactDefaultPerf._allMeasurements);
var summary = ReactDefaultPerfAnalysis.getExclusiveSummary(measurements);
console.table(summary.map(function(item) {
return {
Expand All @@ -93,7 +104,7 @@ var ReactDefaultPerf = {
},

printInclusive: function(measurements) {
measurements = measurements || ReactDefaultPerf._allMeasurements;
measurements = unwrapLegacyMeasurements(measurements || ReactDefaultPerf._allMeasurements);
var summary = ReactDefaultPerfAnalysis.getInclusiveSummary(measurements);
console.table(summary.map(function(item) {
return {
Expand All @@ -109,6 +120,7 @@ var ReactDefaultPerf = {
},

getMeasurementsSummaryMap: function(measurements) {
measurements = unwrapLegacyMeasurements(measurements);
var summary = ReactDefaultPerfAnalysis.getInclusiveSummary(
measurements,
true
Expand All @@ -123,7 +135,7 @@ var ReactDefaultPerf = {
},

printWasted: function(measurements) {
measurements = measurements || ReactDefaultPerf._allMeasurements;
measurements = unwrapLegacyMeasurements(measurements || ReactDefaultPerf._allMeasurements);
console.table(ReactDefaultPerf.getMeasurementsSummaryMap(measurements));
console.log(
'Total time:',
Expand All @@ -132,7 +144,7 @@ var ReactDefaultPerf = {
},

printDOM: function(measurements) {
measurements = measurements || ReactDefaultPerf._allMeasurements;
measurements = unwrapLegacyMeasurements(measurements || ReactDefaultPerf._allMeasurements);
var summary = ReactDefaultPerfAnalysis.getDOMSummary(measurements);
console.table(summary.map(function(item) {
var result = {};
Expand Down