Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use loose-envify instead of envify #6303

Merged
merged 1 commit into from
Mar 21, 2016
Merged

Conversation

qerub
Copy link
Contributor

@qerub qerub commented Mar 19, 2016

As per discussion in #6252. This reduces the number of transitive dependencies and decreases the build time (by ~6% on my machine). I've confirmed that the compiled artifacts are identical to those generated by envify.

@@ -2,7 +2,7 @@

'use strict';

var envify = require('envify/custom');
var envify = require('loose-envify/loose-envify');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave the /custom bit - the API matches envify so we can keep that part the same.

@zpao zpao added this to the 15.0 milestone Mar 21, 2016
This reduces the number of transitive dependencies and decreases the build time (by ~6% on my machine).
@qerub qerub force-pushed the use-loose-envify branch from 5210b01 to ecf824c Compare March 21, 2016 19:18
@facebook-github-bot
Copy link

@qerub updated the pull request.

@zpao
Copy link
Member

zpao commented Mar 21, 2016

Thanks!

zpao added a commit that referenced this pull request Mar 21, 2016
Use loose-envify instead of envify
@zpao zpao merged commit 40c4635 into facebook:master Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants