Keep reference equality if possible in update() #6353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For $set and $apply it is cheap and easy to check whether the new value will be identical (===) to the old value and create a new object only when this is not the case. This will reduce excessive renders when using the pureRenderMixin. The same should be possible for for merge, but is more complicated so is not attempted here.
Contributor
|
@gaearon updated the pull request. |
Collaborator
Author
|
Ultimately we made a decision to not ship any more changes to I’m closing this PR for that reason. If someone wants to fork Thank you for understanding! |
This was referenced Apr 1, 2016
Contributor
|
@gaearon updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged #4968 locally and then made a few changes on top that I thought would be welcome:
I figured I’d run this by Travis as well so I’m submitting it as a PR.
Credits for making this change happen go to @davidmason, I’m just tweaking minor things.
I intend this to land in 15 RC3.