Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never insert <object> lazily in DOMLazyTree #6640

Closed
wants to merge 1 commit into from
Closed

Never insert <object> lazily in DOMLazyTree #6640

wants to merge 1 commit into from

Conversation

syranide
Copy link
Contributor

@syranide syranide commented Apr 28, 2016

#6629

I'm not sure about performance implications or if this might apply to some other node type (I doubt it).

For posterity, I'm unable to update the PR for some reason, but the actual code is:

function queueChild(parentTree, childTree) {
  // Flash Player (and perhaps <object> in general) is created immediately
  // upon inserting into the DOM, so <param> children will not exist yet.
  // This only appends the immediate children right away, but <param> must not
  // be nested so it's good enough.
  if (enableLazy &&
      !(parentTree.node.nodeName &&
        parentTree.node.nodeName.toLowerCase() === 'object')) {
    parentTree.children.push(childTree);
  } else {
    parentTree.node.appendChild(childTree.node);
  }
}

@syranide
Copy link
Contributor Author

Bad fix, this doesn't actually work with nesting inside the object...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants