Skip to content

Conversation

@syranide
Copy link
Contributor

@syranide syranide commented Apr 28, 2016

#6629

I'm not sure about performance implications or if this might apply to some other node type (I doubt it).

For posterity, I'm unable to update the PR for some reason, but the actual code is:

function queueChild(parentTree, childTree) {
  // Flash Player (and perhaps <object> in general) is created immediately
  // upon inserting into the DOM, so <param> children will not exist yet.
  // This only appends the immediate children right away, but <param> must not
  // be nested so it's good enough.
  if (enableLazy &&
      !(parentTree.node.nodeName &&
        parentTree.node.nodeName.toLowerCase() === 'object')) {
    parentTree.children.push(childTree);
  } else {
    parentTree.node.appendChild(childTree.node);
  }
}

@syranide
Copy link
Contributor Author

Bad fix, this doesn't actually work with nesting inside the object...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants