Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ReactIOS components to ReactNative #6643

Merged
merged 2 commits into from
May 3, 2016

Conversation

javache
Copy link
Member

@javache javache commented Apr 28, 2016

None of these components are iOS specific, so change the prefix to ReactNative and move them to the common folder.

@jimfb
Copy link
Contributor

jimfb commented Apr 28, 2016

@sebmarkbage @zpao

@sebmarkbage
Copy link
Collaborator

You can also just move them up one level. I only kept this folder structure while I was constantly rebasing.

@sebmarkbage
Copy link
Collaborator

Accepted. Feel free to hit Squash and Merge when you're ready.

@ghost
Copy link

ghost commented May 3, 2016

@javache updated the pull request.

@javache javache merged commit 222f508 into facebook:master May 3, 2016
@javache javache deleted the remove-reactios branch May 3, 2016 13:05
zpao pushed a commit that referenced this pull request May 3, 2016
* Move ReactIOS components to ReactNative
* Drop ReactNative subfolder
(cherry picked from commit 222f508)
@zpao zpao added this to the 15.0.3 milestone May 3, 2016
@zpao zpao modified the milestones: 15.0.3, 15.y.z, 15.1.0 May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants