Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept a Node engine of version 6.X.X #6645

Merged
merged 1 commit into from
Apr 28, 2016
Merged

Conversation

RaitoBezarius
Copy link
Contributor

This should fix #6644 -- I ran the test suite with Node v6.0.0 and NPM v3.8.6, all the tests were passing.
Thanks in advance!

@zpao
Copy link
Member

zpao commented Apr 28, 2016

Yea, this should be fine. Thanks :)

@zpao zpao merged commit 9d201ab into facebook:master Apr 28, 2016
@keyz
Copy link
Contributor

keyz commented Apr 28, 2016

When I run npm run build with node v6.0.0, the first 2 tasks (delete-build-modules and build-modules) warn about an outdated graceful-fs dep. The warnings don't show up when building on node v5.11.0.

I'm not sure which package has this dependency tho. Seems like it's gulp related. Should this be updated @zpao?

> grunt build

Running "delete-build-modules" task
(node:32080) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
[14:43:14] Using gulpfile ~/fb/react/gulpfile.js
[14:43:14] Starting 'react:clean'...
[14:43:14] Finished 'react:clean' after 34 ms

Running "build-modules" task
(node:32081) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
[14:43:14] Using gulpfile ~/fb/react/gulpfile.js
[14:43:14] Starting 'react:modules'...

@zpao
Copy link
Member

zpao commented Apr 28, 2016

Not much we can do if it's a dep we don't own. If you want to hunt it down and file an issue against whatever package is to blame, I encourage that :)

@keyz
Copy link
Contributor

keyz commented Apr 28, 2016

@zpao It's related to tooling issues like #6433. For instance, grunt 0.4.x requires glob that requires "graceful-fs": "~1.2.0".

However, I just diffed the build outputs on v6 and v5 and there's no difference. I guess we can ignore the warnings for now. 😀

@keyz
Copy link
Contributor

keyz commented Apr 28, 2016

Oh that being said, should node v5 and v6 be added to the travis build matrix? @zpao

@RaitoBezarius RaitoBezarius deleted the bug/node6 branch April 28, 2016 20:48
@zpao
Copy link
Member

zpao commented Apr 28, 2016

Nah, we generally recommend using (and most/all of the team uses) LTS versions for sanity so I think we'll just do that on Travis to cut down on the build matrix. Build output should be the same regardless.

@zpao zpao added this to the 15-next milestone Jun 1, 2016
zpao pushed a commit to zpao/react that referenced this pull request Jun 8, 2016
zpao pushed a commit that referenced this pull request Jun 14, 2016
@zpao zpao modified the milestones: 15-next, 15.2.0 Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React does not support Node v6.0.0
3 participants