-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept a Node engine of version 6.X.X #6645
Conversation
Yea, this should be fine. Thanks :) |
When I run I'm not sure which package has this dependency tho. Seems like it's gulp related. Should this be updated @zpao?
|
Not much we can do if it's a dep we don't own. If you want to hunt it down and file an issue against whatever package is to blame, I encourage that :) |
Oh that being said, should node v5 and v6 be added to the travis build matrix? @zpao |
Nah, we generally recommend using (and most/all of the team uses) LTS versions for sanity so I think we'll just do that on Travis to cut down on the build matrix. Build output should be the same regardless. |
(cherry picked from commit 9d201ab)
(cherry picked from commit 9d201ab)
This should fix #6644 -- I ran the test suite with Node v6.0.0 and NPM v3.8.6, all the tests were passing.
Thanks in advance!