Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar correction in ReactDOMInput.js warning #6657

Merged
merged 1 commit into from
May 2, 2016

Conversation

jakeboone02
Copy link
Contributor

Changed "a uncontrolled input" to "an uncontrolled input".

@jimfb
Copy link
Contributor

jimfb commented Apr 29, 2016

@jakeboone02 You will need to fix the unit tests to match. See https://github.com/facebook/react/pull/6591/files

@jakeboone02
Copy link
Contributor Author

Thanks, @jimfb. I didn't see #6591. Looks like that covers it, so I'll close this one.

@jimfb
Copy link
Contributor

jimfb commented Apr 29, 2016

@jakeboone02 The original author of that PR hasn't responded in a week. If you want to fix the tests in your PR, we could merge this one. Your call.

@jakeboone02 jakeboone02 reopened this Apr 29, 2016
@@ -7966,7 +7966,7 @@ var ReactDOMInput = {
var owner = inst._currentElement._owner;

if ((initialValue || !inst._wrapperState.controlled) && controlled && !didWarnUncontrolledToControlled) {
"development" !== 'production' ? warning(false, '%s is changing a uncontrolled input of type %s to be controlled. ' + 'Input elements should not switch from uncontrolled to controlled (or vice versa). ' + 'Decide between using a controlled or uncontrolled input ' + 'element for the lifetime of the component. More info: https://fb.me/react-controlled-components', owner && owner.getName() || 'A component', props.type) : void 0;
"development" !== 'production' ? warning(false, '%s is changing an uncontrolled input of type %s to be controlled. ' + 'Input elements should not switch from uncontrolled to controlled (or vice versa). ' + 'Decide between using a controlled or uncontrolled input ' + 'element for the lifetime of the component. More info: https://fb.me/react-controlled-components', owner && owner.getName() || 'A component', props.type) : void 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per note in other PR, this file is auto-generated and should not be changed. Please update the PR such that this file remains unchanged.

@jimfb
Copy link
Contributor

jimfb commented Apr 29, 2016

Looks good, just same comment as in the other PR.

@ghost
Copy link

ghost commented Apr 29, 2016

@jakeboone02 updated the pull request.

@jakeboone02
Copy link
Contributor Author

OK, working on this. I'll squash to one commit as well.

Changed "a uncontrolled input" to "an uncontrolled input".
@ghost
Copy link

ghost commented Apr 29, 2016

@jakeboone02 updated the pull request.

@jimfb
Copy link
Contributor

jimfb commented May 2, 2016

Thanks @jakeboone02!

@jimfb jimfb merged commit 393a179 into facebook:master May 2, 2016
@jakeboone02 jakeboone02 deleted the patch-1 branch May 2, 2016 22:23
@zpao zpao added this to the 15.0.x milestone May 2, 2016
zpao pushed a commit that referenced this pull request May 10, 2016
Changed "a uncontrolled input" to "an uncontrolled input".
(cherry picked from commit 393a179)
@zpao zpao modified the milestones: 15.0.x, 15.0.3 May 10, 2016
@zpao zpao modified the milestones: 15.0.3, 15.y.z May 20, 2016
@zpao zpao modified the milestones: 15.1.0, 15.y.z May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants