-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grammar correction in ReactDOMInput.js warning #6657
Conversation
@jakeboone02 You will need to fix the unit tests to match. See https://github.com/facebook/react/pull/6591/files |
@jakeboone02 The original author of that PR hasn't responded in a week. If you want to fix the tests in your PR, we could merge this one. Your call. |
@@ -7966,7 +7966,7 @@ var ReactDOMInput = { | |||
var owner = inst._currentElement._owner; | |||
|
|||
if ((initialValue || !inst._wrapperState.controlled) && controlled && !didWarnUncontrolledToControlled) { | |||
"development" !== 'production' ? warning(false, '%s is changing a uncontrolled input of type %s to be controlled. ' + 'Input elements should not switch from uncontrolled to controlled (or vice versa). ' + 'Decide between using a controlled or uncontrolled input ' + 'element for the lifetime of the component. More info: https://fb.me/react-controlled-components', owner && owner.getName() || 'A component', props.type) : void 0; | |||
"development" !== 'production' ? warning(false, '%s is changing an uncontrolled input of type %s to be controlled. ' + 'Input elements should not switch from uncontrolled to controlled (or vice versa). ' + 'Decide between using a controlled or uncontrolled input ' + 'element for the lifetime of the component. More info: https://fb.me/react-controlled-components', owner && owner.getName() || 'A component', props.type) : void 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per note in other PR, this file is auto-generated and should not be changed. Please update the PR such that this file remains unchanged.
Looks good, just same comment as in the other PR. |
@jakeboone02 updated the pull request. |
OK, working on this. I'll squash to one commit as well. |
Changed "a uncontrolled input" to "an uncontrolled input".
@jakeboone02 updated the pull request. |
Thanks @jakeboone02! |
Changed "a uncontrolled input" to "an uncontrolled input". (cherry picked from commit 393a179)
Changed "a uncontrolled input" to "an uncontrolled input".