Move instrumentation to renderers/shared. Closes #6797 #6801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'setState(...): You passed an undefined or null state object; ' + | ||
| 'instead, use forceUpdate().' | ||
| ); | ||
| } | ||
| this.updater.enqueueSetState(this, partialState); |
There was a problem hiding this comment.
this.updater falls back to the ReactNoopUpdateQueuewhich is also in isomorphic/modern/class/. Is it okay to not call ReactInstrumentation.debugTool.onSetState() in that scenario?
There was a problem hiding this comment.
Is it okay to not call ReactInstrumentation.debugTool.onSetState() in that scenario?
Yea, I think it’s fine.
ghost
added
|
Hmm. Doesn’t this move to |
iamdustan
force-pushed
the
instrumentation-to-shared
branch
from
69ca6d3
to
d51981e
Compare
|
Doh. Updated. Git view (Minimal) Tree view |
|
@iamdustan updated the pull request. |
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Jun 8, 2016
…ared Move instrumentation to renderers/shared. Closes facebook#6797 (cherry picked from commit d125682)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the initial report I also moved ReactPerf out, which maybe should be moved back? Also you may want me to move some files around, yet. The following is the git log version of the moves:
rename src/{isomorphic => shared}/ReactPerf.js (100%) rename src/{isomorphic => shared}/__tests__/ReactPerf-test.js (100%) rename src/{isomorphic => shared}/devtools/ReactComponentTreeDevtool.js (100%) rename src/{isomorphic => shared}/devtools/ReactHostOperationHistoryDevtool.js (100%) rename src/{isomorphic => shared}/devtools/ReactInvalidSetStateWarningDevTool.js (100%) rename src/{isomorphic => shared}/devtools/__tests__/ReactComponentTreeDevtool-test.js (100%) rename src/{isomorphic => shared}/devtools/__tests__/ReactComponentTreeDevtool-test.native.js (100%) rename src/{isomorphic => shared}/devtools/__tests__/ReactHostOperationHistoryDevtool-test.js (100%) rename src/{isomorphic => shared/utils}/ReactDebugTool.js (100%) rename src/{isomorphic => shared/utils}/ReactInstrumentation.js (100%) rename src/{isomorphic => shared/utils}/__tests__/ReactDebugTool-test.js (100%)But it may be easier to see the added files in this treeview (with only added files kept):