Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe fix IE autocomplete misses #6806

Closed
wants to merge 1 commit into from
Closed

Maybe fix IE autocomplete misses #6806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/renderers/dom/client/eventPlugins/ChangeEventPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,17 +273,21 @@ function handleEventsForInputEventIE(
}
}

// For IE8 and IE9.
// For <=IE11.
function getTargetInstForInputEventIE(
topLevelType,
targetInst
) {
if (topLevelType === topLevelTypes.topSelectionChange ||
topLevelType === topLevelTypes.topKeyUp ||
topLevelType === topLevelTypes.topKeyDown) {
topLevelType === topLevelTypes.topKeyDown ||
topLevelType === topLevelTypes.topChange) {
// On the selectionchange event, the target is just document which isn't
// helpful for us so just check activeElement instead.
//
// The onChange event catches autocomplete changes for IE11 where
// onpropertychange doesn't fire.
//
// 99% of the time, keydown and keyup aren't necessary. IE8 fails to fire
// propertychange on the first input event after setting `value` from a
// script and fires only keydown, keypress, keyup. Catching keyup usually
Expand Down