Fix componentWillUnmount() not counted by ReactPerf #6858
Merged
+81
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
@gaearon updated the pull request. |
|
👍 I assume we already have tests to make sure renders due to setState are instrumented? Because that's a different code path than the top-level renders. Thanks for including a top-level update though. |
|
We currently don’t, sorry 😄 . I’ll add a |
|
@gaearon updated the pull request. |
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Jun 8, 2016
* Fix componentWillUnmount() not counted by ReactPerf * Test that functional component render() time shows up in ReactPerf * Test for setState() code path updates being included (cherry picked from commit 9ba5668)
zpao
pushed a commit
that referenced
this pull request
Jun 14, 2016
* Fix componentWillUnmount() not counted by ReactPerf * Test that functional component render() time shows up in ReactPerf * Test for setState() code path updates being included (cherry picked from commit 9ba5668)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
componentWillUnmount()not being measured becauseReactDebugTooldoesn’t realize there is a flush going on. Also adding tests to check that all lifecycle methods are instrumented.