Fix line lengths and test for lint/test passing. #6909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
| @@ -42,7 +42,9 @@ export type ReactYield = { | |||
| continuation: mixed | |||
| }; | |||
|
|
|||
| exports.createCoroutine = function<T>(children : mixed, handler : CoroutineHandler<T>, props : T, key : ?string = null) : ReactCoroutine { | |||
| exports.createCoroutine = function<T>( | |||
There was a problem hiding this comment.
We generally wrap long arg lists like this, can you tweak it?
There was a problem hiding this comment.
Yes, no problem. To avoid an extra commit, will it work for me to amend the commit and force push to my fork? Or I can make a new pull request. What do you prefer?
There was a problem hiding this comment.
GitHub supports "squash and merge" now so feel free to add a new commit.
There was a problem hiding this comment.
Adjusted line breaks to match reviewer feedback.
|
@lexjacobs updated the pull request. |
|
@lexjacobs updated the pull request. |
|
@lexjacobs updated the pull request. |
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Jun 8, 2016
(cherry picked from commit 29ed7c6)
zpao
pushed a commit
that referenced
this pull request
Jun 14, 2016
(cherry picked from commit 29ed7c6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA completed.
grunt testandgrunt lintwere both failing.This pull request remedies that.