Warn if childContextType is defined on SFC #6933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
aweary
force-pushed
the
warn-child-context-sfc
branch
from
80b7506
to
595ae2c
Compare
|
@aweary updated the pull request. |
Add console.error message content check Use appropriate name in warning/test
aweary
force-pushed
the
warn-child-context-sfc
branch
from
595ae2c
to
a303017
Compare
|
@aweary updated the pull request. |
|
Everything is technically public API. cc @facebook/react-core I like it, and Ben gave the conceptual signoff, so I'm shipping it. Also over a week old/reviewed/green. |
zpao
pushed a commit
that referenced
this pull request
Jun 14, 2016
Add console.error message content check Use appropriate name in warning/test (cherry picked from commit c47830d)
gaearon
added a commit
that referenced
this pull request
Jul 5, 2016
zpao
pushed a commit
that referenced
this pull request
Jul 8, 2016
usmanajmal
pushed a commit
to usmanajmal/react
that referenced
this pull request
Jul 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6926
Per the discussion there, this only warns for
childContextTypesfor now.reactEurope-hackathon