Build renderers into their individual npm packages #7168

sebmarkbage · 2016-07-02T09:00:16Z

Builds on top of #7164 with one commit 7c6a95c

This copies modules into three separate packages instead of putting it all in React.

The overlap in shared folders gets duplicated.

This allows the isomorphic package to stay minimal. It can also be used as a direct dependency without much risk.

This also allow us to ship versions to each renderer independently and we can ship renderers without updating the main react package dependency.

sebmarkbage · 2016-07-02T18:19:07Z

The next step would be to flat bundle these.

One benefit of this is that we don't actually have to use react-native-renderer in React Native nor react-dom in FB (www). We can just copy in those source files instead of the bundle if we want.

As long as we use the react npm package as the source of truth, then third party components (minus the ones using findDOMNode), in the npm world, will just work in those environments since that's what they depend on.

I'm still a bit skeptical of the copying strategy because it delays use of smart build systems (optimizing compilers like closure compiler, emscripten for hot paths, Reason, etc) if we're limited to also getting those systems integrated into the downstreams.

sebmarkbage · 2016-07-05T18:48:12Z

We might want to build the fiber renderer as its own standalone npm package that anyone can use to build a renderer. That would be great for React ART, and therefore anyone building a renderer in an external repo.

We only really need the duplication for the existing stateful DI.

gaearon · 2016-07-05T18:49:31Z

We might want to build the fiber renderer as its own standalone npm package that anyone can use to build a renderer.

👍 I think this would be amazing for learning and experimentation!

Without this we end up bundling all of the isomorphic React into the DOM bundle. This was fixed in facebook#7168 too but I'll just do an early fix to ensure that facebook#7168 is purely an npm change.

Without this we end up bundling all of the isomorphic React into the DOM bundle. This was fixed in #7168 too but I'll just do an early fix to ensure that #7168 is purely an npm change.

zpao · 2016-08-10T00:39:21Z

grunt/config/browserify.js

  './ReactCurrentOwner': SECRET_INTERNALS_NAME + '.ReactCurrentOwner',
  './ReactComponentTreeHook': SECRET_INTERNALS_NAME + '.ReactComponentTreeHook',
+  // All these methods are shared are exposed.


zpao · 2016-08-10T17:13:45Z

Alright, let's do it. Let's just fix the addons packaging bit and it's good to go.

sebmarkbage · 2016-08-11T00:26:01Z

src/renderers/testing/ReactTestRenderer.js

@@ -141,7 +139,6 @@ var ReactTestRenderer = {

  /* eslint-disable camelcase */
  unstable_batchedUpdates: ReactUpdates.batchedUpdates,
-  unstable_renderSubtreeIntoContainer: renderSubtreeIntoContainer,


This shouldn't be in the test renderer according to @spicyj because this currently uses the ReactDOM dependency.

This copies modules into three separate packages instead of putting it all in React. The overlap in shared and between renderers gets duplicated. This allows the isomorphic package to stay minimal. It can also be used as a direct dependency without much risk. This also allow us to ship versions to each renderer independently and we can ship renderers without updating the main react package dependency.

Without this we end up bundling all of the isomorphic React into the DOM bundle. This was fixed in #7168 too but I'll just do an early fix to ensure that #7168 is purely an npm change. (cherry picked from commit ca9167c)

This copies modules into three separate packages instead of putting it all in React. The overlap in shared and between renderers gets duplicated. This allows the isomorphic package to stay minimal. It can also be used as a direct dependency without much risk. This also allow us to ship versions to each renderer independently and we can ship renderers without updating the main react package dependency. (cherry picked from commit 0f004ef)

xgqfrms-GitHub · 2016-11-17T10:56:11Z

old require (CommonJS)

new import (ES6)

This copies modules into three separate packages instead of putting it all in React. The overlap in shared and between renderers gets duplicated. This allows the isomorphic package to stay minimal. It can also be used as a direct dependency without much risk. This also allow us to ship versions to each renderer independently and we can ship renderers without updating the main react package dependency.

ghost added GH Review: review-needed CLA Signed labels Jul 2, 2016

sebmarkbage force-pushed the separatenpmbuilds branch from 7c6a95c to f1e947c Compare July 2, 2016 09:11

sebmarkbage assigned zpao Jul 2, 2016

sebmarkbage mentioned this pull request Jul 2, 2016

[WIP] Gulp conversion #7172

Closed

7 tasks

sebmarkbage force-pushed the separatenpmbuilds branch from f1e947c to 09bb6e8 Compare July 2, 2016 19:13

maxdeviant mentioned this pull request Jul 2, 2016

Gulp: lint, flow, and version-check #7174

Merged

4 tasks

facebook-github-bot added the CLA Signed label Jul 12, 2016

sebmarkbage mentioned this pull request Aug 3, 2016

Specify "files" field for npm packages #7396

Merged

sebmarkbage force-pushed the separatenpmbuilds branch 4 times, most recently from 770b799 to cccb686 Compare August 9, 2016 21:13

sebmarkbage mentioned this pull request Aug 9, 2016

Include React itself in the list of build shims #7453

Merged

sebmarkbage force-pushed the separatenpmbuilds branch from cccb686 to 91d79e0 Compare August 9, 2016 22:08

sebmarkbage force-pushed the separatenpmbuilds branch from 91d79e0 to 531017a Compare August 9, 2016 23:41

zpao reviewed Aug 10, 2016
View reviewed changes

zpao added GH Review: accepted and removed GH Review: review-needed labels Aug 10, 2016

sebmarkbage force-pushed the separatenpmbuilds branch from 531017a to 961cf87 Compare August 11, 2016 00:24

sebmarkbage reviewed Aug 11, 2016
View reviewed changes

sebmarkbage force-pushed the separatenpmbuilds branch from 961cf87 to 7e9cb5d Compare August 11, 2016 00:45

sebmarkbage force-pushed the separatenpmbuilds branch from 7e9cb5d to d995587 Compare August 11, 2016 00:59

sebmarkbage merged commit 0f004ef into facebook:master Aug 11, 2016

gaearon mentioned this pull request Aug 13, 2016

ReactComponentTreeHook should not end up in the production build #7492

Closed

iamdustan mentioned this pull request Aug 22, 2016

Update for React core/renderer changes iamdustan/tiny-react-renderer#14

Open

zpao added Project: Package Split labels Sep 8, 2016

zpao modified the milestone: 15-next Sep 8, 2016

Dachaz mentioned this pull request Sep 22, 2016

Added onChange/requestChange support to LinkedInput #7793

Closed

zpao modified the milestones: 15-next, 15.4.0 Oct 4, 2016

jochenberger mentioned this pull request Nov 16, 2016

react-dom 15.4.0 does not work in AMD enviroment #8301

Closed

This was referenced Nov 27, 2016

can't resolve Parallax.js shoutem/ui#93

Closed

NativeMethodsMixin is undefined shoutem/animation#7

Closed

renovate bot mentioned this pull request Feb 2, 2018

Update dependency react to v0.14.9 - autoclosed signavio/backbone-rel#29

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build renderers into their individual npm packages #7168

Build renderers into their individual npm packages #7168

sebmarkbage commented Jul 2, 2016 •

edited

Loading

sebmarkbage commented Jul 2, 2016

sebmarkbage commented Jul 5, 2016

gaearon commented Jul 5, 2016 •

edited

Loading

zpao Aug 10, 2016

zpao commented Aug 10, 2016

sebmarkbage Aug 11, 2016

xgqfrms-GitHub commented Nov 17, 2016

Build renderers into their individual npm packages #7168

Build renderers into their individual npm packages #7168

Conversation

sebmarkbage commented Jul 2, 2016 • edited Loading

sebmarkbage commented Jul 2, 2016

sebmarkbage commented Jul 5, 2016

gaearon commented Jul 5, 2016 • edited Loading

zpao Aug 10, 2016

Choose a reason for hiding this comment

zpao commented Aug 10, 2016

sebmarkbage Aug 11, 2016

Choose a reason for hiding this comment

xgqfrms-GitHub commented Nov 17, 2016

old require (CommonJS)

new import (ES6)

sebmarkbage commented Jul 2, 2016 •

edited

Loading

gaearon commented Jul 5, 2016 •

edited

Loading