Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont mutate event type name, just pass it through #7419

Closed
wants to merge 1 commit into from

Conversation

uxtx
Copy link

@uxtx uxtx commented Aug 3, 2016

This resolves an issue with mutating the type string that was causing some third party test failures

Closes #7418

@ghost
Copy link

ghost commented Aug 3, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@quantizor
Copy link
Contributor

quantizor commented Aug 3, 2016

keyDown isn't a valid native event name, the original behavior is correct and the other implementations are wrong.

@ghost
Copy link

ghost commented Aug 3, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@zpao
Copy link
Member

zpao commented Aug 3, 2016

I appreciate the quick issue filing & PR to address, however as noted it's not actually a problem in React. I commented in #7418 (comment) with more details.

@zpao zpao closed this Aug 3, 2016
@ghost ghost added the CLA Signed label Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ReactTestUtil.Simulate toLowerString mutating event type.
3 participants