Skip to content

Conversation

@vjeux
Copy link
Contributor

@vjeux vjeux commented Aug 28, 2016

As mentioned in #7581 (comment) we can remove the Mixin layer of indirection as it only exports a Mixin and I find it confusing.

As mentioned in facebook#7581 (comment) we can remove the Mixin layer of indirection as it only exports a Mixin and I find it confusing.
@vjeux vjeux mentioned this pull request Aug 28, 2016
@vjeux vjeux added this to the 15-next milestone Aug 28, 2016
@vjeux vjeux merged commit dbe3584 into facebook:master Aug 28, 2016
@sebmarkbage
Copy link
Collaborator

You'll need to update ReactART in its repo too: https://github.com/reactjs/react-art/blob/master/src/ReactART.js#L96

vjeux added a commit to reactjs/react-art that referenced this pull request Aug 29, 2016
@gaearon
Copy link
Collaborator

gaearon commented Aug 29, 2016

What is the plan for ReactART? Now that we moved it here, do we just copy stuff into the separate repo once in a while?

@sophiebits
Copy link
Collaborator

The copy here is only for backwards-compat unit tests. The other repo is the source of truth.

@sophiebits
Copy link
Collaborator

Also, this is not semver-exempt because it breaks react-art. It should be major.

@sophiebits
Copy link
Collaborator

(When you need to change the copy of ReactART in this repo to make tests pass, it's a major change.)

@gaearon
Copy link
Collaborator

gaearon commented Aug 29, 2016

Oh, okay, sorry.
Isn’t the plan to release ReactART that contains a reconciler copy in the next version, like RN?

@sophiebits
Copy link
Collaborator

That's probably a good idea but someone needs to make it happen. :)

@sebmarkbage
Copy link
Collaborator

sebmarkbage commented Aug 29, 2016

The way it works now, it is integrated with the DOM renderer. It will simply change its dependency to depend on react-dom/lib. When we move it to fiber it'll get its fully own renderer though.

@aweary aweary modified the milestones: 16.0, 15-next Aug 30, 2016
superbuddyy added a commit to superbuddyy/react-art-world that referenced this pull request Aug 9, 2022
jewel0647 added a commit to jewel0647/react-art that referenced this pull request Jun 14, 2024
Oleksandr0305 added a commit to Oleksandr0305/react-art that referenced this pull request Jan 31, 2025
othellodev added a commit to othellodev/react-art that referenced this pull request Aug 29, 2025
chrisgadev added a commit to chrisgadev/react-art that referenced this pull request Aug 29, 2025
AlexisMartz added a commit to AlexisMartz/toawes that referenced this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants