-
Notifications
You must be signed in to change notification settings - Fork 50.2k
Remove the Mixin layer of indirection on ReactMultiChild #7598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As mentioned in facebook#7581 (comment) we can remove the Mixin layer of indirection as it only exports a Mixin and I find it confusing.
|
You'll need to update ReactART in its repo too: https://github.com/reactjs/react-art/blob/master/src/ReactART.js#L96 |
|
What is the plan for ReactART? Now that we moved it here, do we just copy stuff into the separate repo once in a while? |
|
The copy here is only for backwards-compat unit tests. The other repo is the source of truth. |
|
Also, this is not semver-exempt because it breaks react-art. It should be major. |
|
(When you need to change the copy of ReactART in this repo to make tests pass, it's a major change.) |
|
Oh, okay, sorry. |
|
That's probably a good idea but someone needs to make it happen. :) |
|
The way it works now, it is integrated with the DOM renderer. It will simply change its dependency to depend on |
As mentioned in #7581 (comment) we can remove the Mixin layer of indirection as it only exports a Mixin and I find it confusing.