Skip to content

Update to Flow v0.33.0 #7841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeffmo wants to merge 1 commit into from
Closed

Update to Flow v0.33.0 #7841

jeffmo wants to merge 1 commit into from

Conversation

@jeffmo
Copy link
Contributor

@jeffmo jeffmo commented Sep 30, 2016

Ran grunt lint and npm run flow. No lint or Flow errors

zpao
zpao requested changes Oct 3, 2016
View reviewed changes
src/renderers/dom/client/eventPlugins/SimpleEventPlugin.js
}

function shouldPreventMouseEvent(inst) {
function shouldPreventMouseEvent(inst?: SyntheticEvent) {
Copy link
Member

@zpao zpao Oct 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a SyntheticEvent. The type we have flowing from where this is called in extractEvents says this should be ReactInstance

@sophiebits sophiebits self-assigned this Oct 4, 2016
@iamdustan iamdustan mentioned this pull request Oct 18, 2016
Merged
@gaearon
Copy link
Collaborator

gaearon commented Oct 18, 2016

Thanks. I fixed the inst type in #8006 so I'll go ahead with that one.

@gaearon gaearon closed this Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zpao zpao zpao requested changes

Assignees

@sophiebits sophiebits

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jeffmo @gaearon @zpao @sophiebits @facebook-github-bot