-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused injectComponentClasses and tagToComponentClass #8050
Remove unused injectComponentClasses and tagToComponentClass #8050
Conversation
Thanks for the PR @diegomura! It actually looks like we don't even use You're change would be correct, but if we're not using it at all I wonder if we should just remove it? /cc @spicyj |
Yes, we should just delete this. |
@diegomura do you want to update your PR to delete |
Thanks guys!
I have no problem on changing my PR if you think is for the best @spicyj @aweary |
Yeah, I don't think there are any plans for supporting a public API for custom renderers with this reconciler at the moment. We should treat this code as internal. |
Yeah, putting the switch/lookup/delegation code in your own host component would be best. |
Thank you @diegomura! |
…ciler (facebook#8050) * Consider Host Component classes when creating a new internal instance * Remove unused tagToComponentClass & injectComponentClasses from ReactHostComponent
tagToComponentClass attribute of ReactHostComponent is not being used when creating an internal component, making useless to inject a Host Component class by the tag name.
The reconciler should check if there is a proper class implementation for a specific tag, and if not, return a generic component class instance.