Shares debugID information across modules #8097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
|
Thanks for the PR @goatslacker, looks reasonable to me. |
|
Emailed the CLA info. |
aweary
previously requested changes
Oct 26, 2016
| @@ -0,0 +1,9 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
We need to add the header document comment here like the other files (example).
Without the @providesModule comment the haste module system doesn't know where to find this file and tests fail.
Prior to this, React was using a nextDebugID variable that was locally scoped to both `instantiateReactComponent` and `ReactShallowRenderer`. This caused problems when the debugIDs would collide, the `itemMap` in `ReactComponentTreeHook` would be overwritten and tests would fail with the message "Expected onBeforeMountComponent() parent and onSetChildren() to be consistent". This change shares the debugID with both modules thus preventing any collisions in the future.
facebook-github-bot
added
GH Review: review-needed
CLA Signed
and removed
GH Review: needs-revision
labels
|
Thanks. |
zpao
pushed a commit
that referenced
this pull request
Nov 16, 2016
Prior to this, React was using a nextDebugID variable that was locally scoped to both `instantiateReactComponent` and `ReactShallowRenderer`. This caused problems when the debugIDs would collide, the `itemMap` in `ReactComponentTreeHook` would be overwritten and tests would fail with the message "Expected onBeforeMountComponent() parent and onSetChildren() to be consistent". This change shares the debugID with both modules thus preventing any collisions in the future. (cherry picked from commit 6eebed0)
|
Out in 15.4.0. |
4 tasks
jstejada
added a commit
to nylas/nylas-mail
that referenced
this pull request
Feb 10, 2017
Now that we have 15.4.2, we don't have to worry about: facebook/react#8097
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
Prior to this, React was using a nextDebugID variable that was locally scoped to both `instantiateReactComponent` and `ReactShallowRenderer`. This caused problems when the debugIDs would collide, the `itemMap` in `ReactComponentTreeHook` would be overwritten and tests would fail with the message "Expected onBeforeMountComponent() parent and onSetChildren() to be consistent". This change shares the debugID with both modules thus preventing any collisions in the future.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, React was using a nextDebugID variable that was locally
scoped to both
instantiateReactComponentandReactShallowRenderer.This caused problems when the debugIDs would collide, the
itemMapinReactComponentTreeHookwould be overwritten and tests would failwith the message "Expected onBeforeMountComponent() parent and
onSetChildren() to be consistent".
This change shares the debugID with both modules thus preventing any
collisions in the future.
Fixes #7927
Ideally this would be in the next (hotfix?) release of React 15.x as this is preventing us (Airbnb) from upgrading at the moment.