Skip to content

Conversation

@dtinth
Copy link

@dtinth dtinth commented Oct 26, 2016

Before submitting a pull request, please make sure the following is done...

  • This branch branched of the master branch.
  • Only documentation changes.
  • CLA signed.

For <input> and <textarea>, onChange should generally used instead of — the DOM's built-in oninput event handler.

Since onChange is the prop that the user should use, the sentence should use a passive voice.

I’m still not sure why we need an “—” in instead of — the DOM's built-in oninput event handler. Or should the sentence be rewritten, e.g., in active voice (you should generally use onChange instead of the DOM's built-in oninput event handler.)?

Since `onChange` is the prop that the user should use, it should use a
passive voice.
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status.

@gaearon
Copy link
Collaborator

gaearon commented Oct 26, 2016

Thanks for the PR! We were fixing other issues in that document so this got fixed as part of #8115. This now has conflicts so we won't pick it, but we appreciate your effort!

@gaearon gaearon closed this Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants